QtGeolocation provider does not work due "using namespace QtMobility;" in cpp, not header

RESOLVED FIXED in mozilla22

Status

()

Core
Geolocation
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Andrey, Assigned: Andrey)

Tracking

Trunk
mozilla22
ARM
MeeGo
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

(Assignee)

Description

4 years ago
Just compiled and tested embedlite branch on Nokia N9, got an error while using HTML5 location tests:

Object::connect: No such slot QTMLocationProvider::positionUpdated(QGeoPositionInfo) in /home/coderus/mozilla-central/dom/system/unix/QTMLocationProvider.cpp:19

Checked sources and found bug in using namespace QtMobility

file: /dom/system/unix/QTMLocationProvider.h
need to move from cpp file
using namespace QtMobility;
(Assignee)

Updated

4 years ago
Depends on: 847382
Blocks: 815047
Status: UNCONFIRMED → NEW
No longer depends on: 847382
Ever confirmed: true
(Assignee)

Comment 1

4 years ago
Created attachment 721590 [details] [diff] [review]
patch
(Assignee)

Updated

4 years ago
Attachment #721590 - Flags: review?(romaxa)
Comment on attachment 721590 [details] [diff] [review]
patch

Please use hg/git diff -U8
Also add some header to patch, see example in 
https://bug815047.bugzilla.mozilla.org/attachment.cgi?id=685045
(Assignee)

Comment 3

4 years ago
Created attachment 721599 [details] [diff] [review]
patch
Attachment #721590 - Attachment is obsolete: true
Attachment #721590 - Flags: review?(romaxa)
Attachment #721599 - Flags: review+
(Assignee)

Updated

4 years ago
Attachment #721599 - Flags: review+ → review?(romaxa)
(Assignee)

Comment 4

4 years ago
Created attachment 721603 [details] [diff] [review]
patch
Attachment #721599 - Attachment is obsolete: true
Attachment #721599 - Flags: review?(romaxa)
Attachment #721603 - Flags: review?(romaxa)
(Assignee)

Comment 5

4 years ago
Created attachment 721766 [details] [diff] [review]
patch
Attachment #721603 - Attachment is obsolete: true
Attachment #721603 - Flags: review?(romaxa)
Attachment #721766 - Flags: review?(romaxa)
Comment on attachment 721766 [details] [diff] [review]
patch

Looks good now.
Attachment #721766 - Flags: review?(romaxa) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/569168aed87a
Assignee: nobody → coderusinbox
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/569168aed87a
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.