Last Comment Bug 845350 - QtGeolocation provider does not work due "using namespace QtMobility;" in cpp, not header
: QtGeolocation provider does not work due "using namespace QtMobility;" in cpp...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Geolocation (show other bugs)
: Trunk
: ARM MeeGo
: -- normal (vote)
: mozilla22
Assigned To: Andrey
:
Mentors:
Depends on:
Blocks: 815047
  Show dependency treegraph
 
Reported: 2013-02-26 08:00 PST by Andrey
Modified: 2013-03-07 09:55 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1001 bytes, patch)
2013-03-05 23:58 PST, Andrey
no flags Details | Diff | Review
patch (1.42 KB, patch)
2013-03-06 00:11 PST, Andrey
no flags Details | Diff | Review
patch (1.56 KB, patch)
2013-03-06 00:19 PST, Andrey
no flags Details | Diff | Review
patch (1.98 KB, patch)
2013-03-06 09:20 PST, Andrey
romaxa: review+
Details | Diff | Review

Description Andrey 2013-02-26 08:00:43 PST
Just compiled and tested embedlite branch on Nokia N9, got an error while using HTML5 location tests:

Object::connect: No such slot QTMLocationProvider::positionUpdated(QGeoPositionInfo) in /home/coderus/mozilla-central/dom/system/unix/QTMLocationProvider.cpp:19

Checked sources and found bug in using namespace QtMobility

file: /dom/system/unix/QTMLocationProvider.h
need to move from cpp file
using namespace QtMobility;
Comment 1 Andrey 2013-03-05 23:58:32 PST
Created attachment 721590 [details] [diff] [review]
patch
Comment 2 Oleg Romashin (:romaxa) 2013-03-06 00:10:14 PST
Comment on attachment 721590 [details] [diff] [review]
patch

Please use hg/git diff -U8
Also add some header to patch, see example in 
https://bug815047.bugzilla.mozilla.org/attachment.cgi?id=685045
Comment 3 Andrey 2013-03-06 00:11:28 PST
Created attachment 721599 [details] [diff] [review]
patch
Comment 4 Andrey 2013-03-06 00:19:31 PST
Created attachment 721603 [details] [diff] [review]
patch
Comment 5 Andrey 2013-03-06 09:20:09 PST
Created attachment 721766 [details] [diff] [review]
patch
Comment 6 Oleg Romashin (:romaxa) 2013-03-06 09:29:12 PST
Comment on attachment 721766 [details] [diff] [review]
patch

Looks good now.
Comment 7 Ryan VanderMeulen [:RyanVM] 2013-03-06 10:09:46 PST
https://hg.mozilla.org/integration/mozilla-inbound/rev/569168aed87a
Comment 8 Ryan VanderMeulen [:RyanVM] 2013-03-07 09:55:37 PST
https://hg.mozilla.org/mozilla-central/rev/569168aed87a

Note You need to log in before you can comment on or make changes to this bug.