847382 - xulrunner builds are broken

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=20291605&tree=Firefox

make -j4 -C obj-firefox sdk
make[1]: Entering directory `/builds/slave/m-cen-lx-xr-ntly-0000000000000/build/obj-firefox'
make: Entering an unknown directory
make: *** xulrunner/installer: No such file or directory.  Stop.
make: Leaving an unknown directory
make[1]: *** [sdk] Error 2

Comment 1

[Mike Hommey [:glandium]]

Attachment: Add missing moz.build definition for xulrunner/installer/Makefile

Comment 2

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b55a438b74e2

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b55a438b74e2

Comment 4

[Alex Vincent [:WeirdAl]]

[ajvincent@localhost xu-opt]$ make sdk
make[1]: Entering directory `/home/ajvincent/trunk/xu-opt/xulrunner/installer'
/home/ajvincent/trunk/mozilla/config/rules.mk:35: backend.mk: No such file or directory
Makefile:72: FULL_NSPR_CFLAGS=-I\${includedir}
make[1]: *** No rule to make target `backend.mk'.  Stop.
make[1]: Leaving directory `/home/ajvincent/trunk/xu-opt/xulrunner/installer'
make: *** [sdk] Error 2

Comment 5

[Alex Vincent [:WeirdAl]]

Attachment: patch 2 (necessary but not sufficient, suggested by m_kato)

This isn't quite enough - the patch for bug 812105 doesn't work.  Probably a relative path problem...

/home/ajvincent/trunk/xu-opt/config/nsinstall -D ../../dist/sdk/
USE_ELF_HACK= /home/ajvincent/trunk/xu-opt/_virtualenv/bin/python toolkit/mozapps/installer/strip.py ../../dist/xulrunner-sdk
/home/ajvincent/trunk/xu-opt/_virtualenv/bin/python: can't open file 'toolkit/mozapps/installer/strip.py': [Errno 2] No such file or directory

Comment 6

[Alex Vincent [:WeirdAl]]

Attachment: patch 2

This does fix the SDK building.

Comment 7

[Alex Vincent [:WeirdAl]]

Attachment: patch 2

sorry about the bugspam; I forgot to export qtip.

Comment 8

[Mike Hommey [:glandium]]

Comment on attachment 721076 [details] [diff] [review]
patch 2

Review of attachment 721076 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/installer/packager.mk
@@ +693,5 @@
>  	(cd $(DIST)/sdk/lib && $(TAR) $(TAR_CREATE_FLAGS) - .) | \
>  	  (cd $(DIST)/$(MOZ_APP_NAME)-sdk/lib && tar -xf -)
>  	$(NSINSTALL) -D $(DIST)/$(SDK_PATH)
>  ifndef PKG_SKIP_STRIP
> +	USE_ELF_HACK= $(PYTHON) $(topsrcdir)/toolkit/mozapps/installer/strip.py $(DIST)/$(MOZ_APP_NAME)-sdk

Use MOZILLA_DIR instead of topsrcdir

Comment 9

[Alex Vincent [:WeirdAl]]

Attachment: patch 2, adjusted for r+

Comment 10

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/015da7030aab

Comment 11

[Ed Morley [:emorley]]

Backed out for not following the tree rules (watching/starring mozilla-central after pushing):
https://hg.mozilla.org/mozilla-central/rev/47876c1d1c45

Comment 12

[Mike Hommey [:glandium]]

Comment on attachment 721083 [details] [diff] [review]
patch 2, adjusted for r+

http://hg.mozilla.org/integration/mozilla-inbound/rev/2c217df0f901

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2c217df0f901

Comment 14

[[e-mail] (:bhearsum)]

Comment on attachment 721083 [details] [diff] [review]
patch 2, adjusted for r+

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Linux XULRunner SDKs are 10x the size they need to be, causing longer downloads for users of them.
Testing completed (on m-c, etc.): Applied patch locally.

Paired with bug 812105.

Comment 15

[[e-mail] (:bhearsum)]

Comment on attachment 721083 [details] [diff] [review]
patch 2, adjusted for r+

10:37 < bhearsum|buildduty> lsblakk: i  just asked for approval for https://bugzilla.mozilla.org/show_bug.cgi?id=812105 and https://bugzilla.mozilla.org/show_bug.cgi?id=847382, but then glandium pointed out to me that a=NPOTB 
                            has been used for xulrunner things before. can i go ahead and land them on beta?
10:43 < lsblakk> ya

https://hg.mozilla.org/releases/mozilla-beta/rev/5f41d8b47686