Closed
Bug 845549
Opened 12 years ago
Closed 12 years ago
Expose an helper to ease testing console output in tests
Categories
(Add-on SDK Graveyard :: General, defect)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.14
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
In various tests we end up having to check what happens with the console
and end up copy pasting a bunch of non-naive piece of code.
It would be better to expose an helper in order to lower the maintenance of these tests.
|
Assignee | |
Comment 1•12 years ago
|
||
I ended up modifying various places where we use that pattern except test-event-target and test-unit-test which doesn't worth the refactoring complexity.
Assignee: nobody → poirot.alex
Attachment #718667 -
Flags: review?(evold)
|
||
Updated•12 years ago
|
Attachment #718667 -
Flags: review?(evold) → review+
|
||
Comment 2•12 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/046db4dbf06ef8c24a50abe6c4d737c2245bc8fd
Bug 845549 - Expose an helper to ease testing console output in tests r=@erikvold
https://github.com/mozilla/addon-sdk/commit/c1e40cd69bbf76a2b0b288d3f3c8e3315fdcdd67
Merge pull request #816 from ochameau/hooked-console
Bug 845549 - Expose an helper to ease testing console output in tests r=@erikvold
|
|
Assignee | |
Comment 3•12 years ago
|
||
To pick up into 1.14 as it is a bug 842448 depends on this patch.
Blocks: 842448
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.14
You need to log in
before you can comment on or make changes to this bug.
Description
•