In various tests we end up having to check what happens with the console and end up copy pasting a bunch of non-naive piece of code. It would be better to expose an helper in order to lower the maintenance of these tests.
Created attachment 718667 [details] Pull request 816 I ended up modifying various places where we use that pattern except test-event-target and test-unit-test which doesn't worth the refactoring complexity.
Assignee: nobody → poirot.alex
Attachment #718667 - Flags: review?(evold)
Attachment #718667 - Flags: review?(evold) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/046db4dbf06ef8c24a50abe6c4d737c2245bc8fd Bug 845549 - Expose an helper to ease testing console output in tests r=@erikvold https://github.com/mozilla/addon-sdk/commit/c1e40cd69bbf76a2b0b288d3f3c8e3315fdcdd67 Merge pull request #816 from ochameau/hooked-console Bug 845549 - Expose an helper to ease testing console output in tests r=@erikvold
To pick up into 1.14 as it is a bug 842448 depends on this patch.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.14
You need to log in before you can comment on or make changes to this bug.