deprecate window.isPrivateBrowsing

RESOLVED FIXED in 1.14

Status

P1
normal
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: evold, Assigned: ochameau)

Tracking

unspecified
1.14
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

require('private-browsing').isPrivate() should be used instead.
Assignee: nobody → evold
Blocks: 748604
Target Milestone: --- → 1.14
Blocks: 841823

Updated

6 years ago
Priority: -- → P1
Assignee: evold → jgriffiths
(Assignee)

Comment 1

6 years ago
It looks like window.isPrivateBrowsing has been introduced by bug 772663 and landed in 1.12, so that two releases have been released with this API and it has even been documented, so that I'd tend to think that we should deprecate it first?

Erik, do you agree about that?

Jeff, do you mind if I provide patch for this?
(In reply to Alexandre Poirot (:ochameau) from comment #1)
> It looks like window.isPrivateBrowsing has been introduced by bug 772663 and
> landed in 1.12, so that two releases have been released with this API and it
> has even been documented, so that I'd tend to think that we should deprecate
> it first?
> 
> Erik, do you agree about that?
> 
> Jeff, do you mind if I provide patch for this?

I hadn't realised that it had shipped already, yes we should go the deprecation route instead
(Assignee)

Updated

6 years ago
Assignee: jgriffiths → poirot.alex
(Assignee)

Comment 3

6 years ago
Created attachment 718674 [details]
Pull request 817

I ended up introducing an helper method in order to ease testing deprecated methods and offloaded this task in bug 845549 / PR #816.
Attachment #718674 - Flags: review?(evold)
Attachment #718674 - Flags: review?(evold) → review+
(Assignee)

Updated

6 years ago
Depends on: 845549

Comment 4

6 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/36d4a1f6674b3814878461bc3f68b46491ebe754
Bug 842448 - Deprecate window.isPrivateBrowsing in favor of require('private-browsing').isPrivate()

https://github.com/mozilla/addon-sdk/commit/e20fb10400ed3a13510d251b1b8fafa6b4eed6f2
Merge pull request #817 from ochameau/window-isprivate

bug 842448 - Deprecate window.isPrivateBrowsing in favor of require('private-browsing').isPrivate() r=@erikvold
(Assignee)

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Blocks: 852338
No longer blocks: 852338
Summary: remove window.isPrivateBrowsing → deprecate window.isPrivateBrowsing
You need to log in before you can comment on or make changes to this bug.