Fix markPageAsXXX usage in Seamonkey

RESOLVED FIXED in seamonkey2.24

Status

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mak, Assigned: mcsmurf)

Tracking

unspecified
seamonkey2.24
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reporter

Description

6 years ago
Bug 839034 moved markPageAs methods from nsIBrowserHistory to nsINavHistoryService, everything should keep working for now, since history implements classinfo, though any reference to nsIBrowserHistory.markPageAs or PlacesUtils.bhistory.markPageAs should be updated.
Reporter

Updated

6 years ago
OS: Windows 7 → All
Hardware: x86_64 → All
Assignee

Comment 2

6 years ago
Parts of this bug here have been fixed in Bug 856208 (Stop using global-history;2 in SeaMonkey code)
Assignee

Comment 3

6 years ago
Posted patch PatchSplinter Review
Neil: I'll likely file a new bug to figure out if we need both utils.js and PlacesUIUtils.jsm (except if you happen to know the answer already).
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #805910 - Flags: review?(neil)
(In reply to Frank Wein from comment #3)
> Neil: I'll likely file a new bug to figure out if we need both utils.js and
> PlacesUIUtils.jsm (except if you happen to know the answer already).

utils.js predates our use of PlacesUIUtils.jsm - it only needed to handle history, not bookmarks, so it was simpler. Probably applies to other parts of suite/common/history.
Attachment #805910 - Flags: review?(neil) → review+
Assignee

Comment 5

6 years ago
Pushed: https://hg.mozilla.org/comm-central/rev/c2bfccc11248
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.24
You need to log in before you can comment on or make changes to this bug.