845895 - Fix markPageAsXXX usage in Seamonkey

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Bug 839034 moved markPageAs methods from nsIBrowserHistory to nsINavHistoryService, everything should keep working for now, since history implements classinfo, though any reference to nsIBrowserHistory.markPageAs or PlacesUtils.bhistory.markPageAs should be updated.

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

I can find entries in
http://mxr.mozilla.org/comm-central/source/suite/common/history/utils.js
http://mxr.mozilla.org/comm-central/source/suite/common/src/PlacesUIUtils.jsm
http://mxr.mozilla.org/comm-central/source/suite/common/contentAreaClick.js

PS: why do you have both utils.js and PlacesUIUtils.jsm?

Comment 2

[Frank Wein [:mcsmurf]]

Parts of this bug here have been fixed in Bug 856208 (Stop using global-history;2 in SeaMonkey code)

Comment 3

[Frank Wein [:mcsmurf]]

Attachment: Patch

Neil: I'll likely file a new bug to figure out if we need both utils.js and PlacesUIUtils.jsm (except if you happen to know the answer already).

Comment 4

[[e-mail]]

(In reply to Frank Wein from comment #3)
> Neil: I'll likely file a new bug to figure out if we need both utils.js and
> PlacesUIUtils.jsm (except if you happen to know the answer already).

utils.js predates our use of PlacesUIUtils.jsm - it only needed to handle history, not bookmarks, so it was simpler. Probably applies to other parts of suite/common/history.

Comment 5

[Frank Wein [:mcsmurf]]

Pushed: https://hg.mozilla.org/comm-central/rev/c2bfccc11248