839034 - move markPageAsXXX methods to nsINavHistoryService

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak] (Away 10-21 August)]

these methods are currently spread half in nsIBrowserHistory and half in nsINavHistoryService, we should just move all of them to nsINavHistoryService.

Comment 1

[Raymond Lee [:raymondlee]]

Attachment: v1

https://tbpl.mozilla.org/?tree=Try&rev=27d729127f07

Comment 2

[Marco Bonardo [:mak] (Away 10-21 August)]

we need also an additional patch for Metro elm project branch, that removes nsIBrowserHistory from here:
http://mxr.mozilla.org/projects-central/source/elm/browser/metro/base/content/browser-scripts.js#57

Comment 3

[Marco Bonardo [:mak] (Away 10-21 August)]

Comment on attachment 711723 [details] [diff] [review]
v1

Review of attachment 711723 [details] [diff] [review]:
-----------------------------------------------------------------

once these comments are fixed we will need a superreview here, gavin may likely do it.
Luckily the ClassInfo on history and the PlacesUIUtils helpers help us with compatibility, I'm now going to check add-ons mxr for breaking usage.

::: toolkit/components/places/nsIBrowserHistory.idl
@@ -108,5 @@
> -     *
> -     * @param aURI
> -     *        URI of the page to be marked.
> -     */
> -    void markPageAsFollowedLink(in nsIURI aURI);

you must rev the UUID here

::: toolkit/components/places/nsINavHistoryService.idl
@@ +1280,5 @@
> +   *
> +   * @param aURI
> +   *        URI of the page to be marked.
> +   */
> +  void markPageAsFollowedLink(in nsIURI aURI);

as well as here

Comment 4

[Marco Bonardo [:mak] (Away 10-21 August)]

As I suspected, the classInfo and PlacesUtils here makes so that most of the add-ons will keep working without changes, I found a couple that are getting a handle through globalhistory2 and while this bug won't break them, bug 838874 will regardless.

Comment 5

[Raymond Lee [:raymondlee]]

Attachment: v2

Rev the UUIDs as suggested in comment 3

Comment 6

[Marco Bonardo [:mak] (Away 10-21 August)]

please see also comment 2

Comment 7

[Raymond Lee [:raymondlee]]

Attachment: Patch for Metro branch

(In reply to Marco Bonardo [:mak] from comment #2)
> we need also an additional patch for Metro elm project branch, that removes
> nsIBrowserHistory from here:
> http://mxr.mozilla.org/projects-central/source/elm/browser/metro/base/
> content/browser-scripts.js#57

Address this.

Comment 8

[Raymond Lee [:raymondlee]]

Attachment: Patch for check-in

Comment 9

[Raymond Lee [:raymondlee]]

Attachment: Patch for check-in for Metro branch

Comment 10

[Marco Bonardo [:mak] (Away 10-21 August)]

the Metro branch has been merged to central some days ago, so both patches can land in inbound

Comment 11

[Marco Bonardo [:mak] (Away 10-21 August)]

Ah I see you already fixed the usage in central, then probably we don't need the metro patch, from what I see they just merge the branch with central periodically.

Comment 12

[Raymond Lee [:raymondlee]]

Passed try
https://tbpl.mozilla.org/?tree=Try&rev=db8b2eb00be8

Comment 13

[Marco Bonardo [:mak] (Away 10-21 August)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e73692553d1f

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e73692553d1f

Comment 15

[Frank Wein [:mcsmurf]]

Just FYI: I updated https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsINavHistoryService and https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIBrowserHistory to reflect the interface changes.

Comment 16

[Marco Bonardo [:mak] (Away 10-21 August)]

thanks, I indeed forgot to set dev-doc-needed :(