these methods are currently spread half in nsIBrowserHistory and half in nsINavHistoryService, we should just move all of them to nsINavHistoryService.
Created attachment 711723 [details] [diff] [review]
we need also an additional patch for Metro elm project branch, that removes nsIBrowserHistory from here:
Comment on attachment 711723 [details] [diff] [review]
Review of attachment 711723 [details] [diff] [review]:
once these comments are fixed we will need a superreview here, gavin may likely do it.
Luckily the ClassInfo on history and the PlacesUIUtils helpers help us with compatibility, I'm now going to check add-ons mxr for breaking usage.
@@ -108,5 @@
> - *
> - * @param aURI
> - * URI of the page to be marked.
> - */
> - void markPageAsFollowedLink(in nsIURI aURI);
you must rev the UUID here
@@ +1280,5 @@
> + *
> + * @param aURI
> + * URI of the page to be marked.
> + */
> + void markPageAsFollowedLink(in nsIURI aURI);
as well as here
As I suspected, the classInfo and PlacesUtils here makes so that most of the add-ons will keep working without changes, I found a couple that are getting a handle through globalhistory2 and while this bug won't break them, bug 838874 will regardless.
Created attachment 711929 [details] [diff] [review]
Rev the UUIDs as suggested in comment 3
please see also comment 2
Created attachment 711947 [details] [diff] [review]
Patch for Metro branch
(In reply to Marco Bonardo [:mak] from comment #2)
> we need also an additional patch for Metro elm project branch, that removes
> nsIBrowserHistory from here:
Created attachment 718803 [details] [diff] [review]
Patch for check-in
Created attachment 718805 [details] [diff] [review]
Patch for check-in for Metro branch
the Metro branch has been merged to central some days ago, so both patches can land in inbound
Ah I see you already fixed the usage in central, then probably we don't need the metro patch, from what I see they just merge the branch with central periodically.
Just FYI: I updated https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsINavHistoryService and https://developer.mozilla.org/en-US/docs/XPCOM_Interface_Reference/nsIBrowserHistory to reflect the interface changes.
thanks, I indeed forgot to set dev-doc-needed :(