846275 - Defect - On first install win8 prompt does not have firefox listed

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Shell, defect, P1)

Description

[Jim Mathies [:jimm]]

STR:

Fresh machine, never installed before.

1) install firefox
2) open firefox desktop - get prompted to set fx as default, click yes

result: two prompts, one centered on the browser window, and one flyout. The centered dialog lists IE and app store without firefox. Clicking on the flyout you get another popup that lists ie and firefox.

Comment 1

[Asa Dotzler [:asa]]

I haven't been able to reproduce this. I uninstalled Firefox, setting IE as the default and then installed a new nightly from m-c and things seemed to work just fine. Any suggestions?

Comment 2

[Jim Mathies [:jimm]]

(In reply to Asa Dotzler [:asa] from comment #1)
> I haven't been able to reproduce this. I uninstalled Firefox, setting IE as
> the default and then installed a new nightly from m-c and things seemed to
> work just fine. Any suggestions?

It happens for fresh installs on new machines. I think uninstalling all versions of firefox and then installing fresh might reproduce as well.

Comment 3

[Brian R. Bondy [:bbondy]]

Jim is it possible that there was something wrong with your machine? I tried with a fresh VM and Firefox is listed in both the Windows flyout and also the prompt once you start the browser.  Perhaps it's an intermittent problem?

Comment 4

[Jim Mathies [:jimm]]

(In reply to Brian R. Bondy [:bbondy] from comment #3)
> Jim is it possible that there was something wrong with your machine? I tried
> with a fresh VM and Firefox is listed in both the Windows flyout and also
> the prompt once you start the browser.  Perhaps it's an intermittent problem?

I experienced this on the very first install on a brand new surface pro. I can't wipe that particular device to reproduce though. We might be able to replicate by working up a registry script that wipes all remnants of fx off a device.

Comment 5

[Brian R. Bondy [:bbondy]]

I think it might be an intermittent problem with the registration not happening fast enough in the background before the prompt is shown.  Maybe whatever triggers Win8 to prompt it we should do after the default browser registration.

Comment 6

[Brian R. Bondy [:bbondy]]

Suggestion for jimm for it5. If you can reproduce with a registry script then try Comment 5 fix.  Flagging Marco for whiteboard fields for defect in it5.

Comment 7

[Marco Mucci [:MarcoM]]

Moving to Iteration #5 for consideration as a defect.

Comment 8

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

I think the thing that makes that first prompt come up is the calls to: `CleanupMetroBrowserHandlerValues` && `AddMetroBrowserHandlerValues`.

I verified and the registry key entry that makes Firefox popup in that menu is: HKEY_CURRENT_USER\Software\Clients\StartMenuInternet\FIREFOX.EXE\Capabilities\URLAssociations\http set to FirefoxURL) 
Which is set in `SetStartMenuInternet`.

So although I can't reproduce, I think the fix here is to ensure that we call `SetStartMenuInternet` before calling `CleanupMetroBrowserHandlerValues` && `AddMetroBrowserHandlerValues`.
It doesn't matter for updates and setting default after the first install because the `SetStartMenuInternet` regkeys would already exist.  That explains why this was only found on a fresh machine.

By the way I was testing with a brand new VM when I worked on this and couldn't reproduce but it makes sense that it could happen on some different machines.

Comment 9

[Jim Mathies [:jimm]]

Comment on attachment 734399 [details] [diff] [review]
Patch v1.

I've still got that 64GB surface sitting around that I've reset, I'll break that out and take the nightly off this for a spin.

Comment 10

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/13943daf18f8

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/13943daf18f8

Comment 12

[Virgil Dicu [:virgil] [QA]]

Mozilla/5.0 (Windows NT 6.2; rv:23.0) Gecko/20130414 Firefox/23.0

Couldn't reproduce the initial issue, but made sure that the flow works as expected on two Win 8 machines. Prompt displayed - Nightly set to default.

Comment 13

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #6 testing. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-04-30-03-09-41-mozilla-central/

Installed Firefox Metro on the following Windows 8 machines:
- Windows 8 x64 & Windows 8 x86 on fresh VM snapshots
- Windows 8 x64 on a desktop
- Windows 8 x64 on a touch ultrabook

Used the following tests on the above machines:

- Installed Firefox Metro using the "Standard" selection and ensured "Nightly" appeared in the "Default" list
- Installed Firefox Metro using the "Custom" selection and ensured "Nightly" appeared in the "Default" list
- Ensured that the entire installation flows worked as expected
- Ensured that once "Nightly" is selected, that it's set as the default browser

Couldn't reproduce the original issue (went through about 3 installations on each of the list machines)

Comment 14

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. I didn't see any issue for two different machines.