846414 - Hide the "Show All Tabs" button when there are less than 2 tabs.

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, enhancement)

Description

[Josiah Bruner [:jsbruner]]

========================

Part of a blog post that we are pushing to redo the TB UI.

Point 7: Only show "show all tabs" button when there are multiple tabs.

For more details see:

http://infinite-josiah.blogspot.com/2013/02/thunderbird-ui-concept.html

========================

It is pointless to show the button that lists all your tabs when you only have one open. In fact, it really is pointless to show them unless you have more tabs than your Window can hold.

This bug is to remove it/hide it when not being useful.

Comment 1

[Stanzilla]

Still waiting for this :)

Comment 2

[Josiah Bruner [:jsbruner]]

Please don't needinfo people without an actual question. I have a lot of things I'm working on and this is not super-high priority.

That said, if someone wants to work on this before I do, the idea is simple enough...

1. After a tab is closed or opened, check if the tabCount > 1.

2. If no, set an attribute on the button.

We can hide the button pretty easily by using this attribute via CSS.

If someone wants to write this up I'll be glad to review it.

Comment 3

[Jim Porter (:squib)]

Ideally, we could do like Firefox and only show the button when there are more tabs than fit on the tab bar.

Comment 4

[Josiah Bruner [:jsbruner]]

Indeed. In which case we just need to check if the tabs bar has an overflow property. Easy enough.

Comment 5

[Richard Marti (:Paenglab)]

Attachment: patch

This patch is similar to Fx, the alltabs-button button is collapsed until the tabs are overflowing.

Comment 6

[Josiah Bruner [:jsbruner]]

Comment on attachment 8369589 [details] [diff] [review]
patch

Review of attachment 8369589 [details] [diff] [review]:
-----------------------------------------------------------------

Brilliant! Thanks.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/b42786120a5d