846524 - Seamonkey build changes for a moz.build compatibility

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Gregory Szorc [:gps]]

comm-central is mostly building the 'mail' app. However, 'suite' needs a bit more love. Establishing a bug to get it working.

Comment 1

[Frank Wein [:mcsmurf]]

Gregory: Can you provide a few hints on how to fix this? Or will you provide a patch?

Comment 2

[Gregory Szorc [:gps]]

(In reply to Frank Wein [:mcsmurf] from comment #1)
> Gregory: Can you provide a few hints on how to fix this? Or will you provide
> a patch?

I took a break from working on this to type this comment. Join in #build for progress updates.

Comment 3

[Gregory Szorc [:gps]]

Attachment: Part 1: Convert chatzilla, v1

Patch supplied by Ms2ger. I think I got the author headers correct! I'll review this.

Do we need to CC any Chatzilla people or can I just push?

Comment 4

[Gregory Szorc [:gps]]

Attachment: Part 2: Convert dom inspector, v1

Same treatment for the dom inspector extension. Anyone need notified or can I just push?

Comment 5

[Gregory Szorc [:gps]]

Attachment: Part 3: Convert venkman, v1

More of the same for venkman. Anybody need notified?

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 720090 [details] [diff] [review]
Part 3: Convert venkman, v1

Review of attachment 720090 [details] [diff] [review]:
-----------------------------------------------------------------

Don't we need STANDALONE_MAKEFILE in locales?

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 720088 [details] [diff] [review]
Part 2: Convert dom inspector, v1

Review of attachment 720088 [details] [diff] [review]:
-----------------------------------------------------------------

Might also be missing STANDALONE_MAKEFILE for this one too.

Comment 8

[Gregory Szorc [:gps]]

I made minor fixes to the patches and pushed to their respective repositories. I self-reviewed a trivial patch to comm-central to fix the path to the extensions directory.

https://hg.mozilla.org/comm-central/rev/952218fceefe

I was able to build Seamonkey locally. So, I'm resolving this bug. Please reopen if it doesn't work on the builders.

I'm not sure if the Target Milestone is correct. I'm sure someone will correct if it isn't!