846532 - Make sure button/field labels don't overflow in non-english locales

Status: RESOLVED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P2)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. On your unagi phone, launch your marketplace-dev
2. Under Settings, change locale = Espanol
3. Navigate to the details page of an app
4. Notice the button labels


observed behavior:
Overflow issues for button labels are noticed. See screenshot

Works fine on desktop.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

We can/should wrap, but let's make the buttons of equal heights so they don't look stupid.

Comment 2

[Potch [:potch]]

I believe the recommendation in this instance is to go to one button per line. How to do that with just CSS is beyond me. I shall ponder on it.

Comment 3

[Maureen Hanratty]

I'm thinking to avoid really tall buttons we might need to make these full width. Michael, what do you think?

Comment 4

[Michael Maslaney [:mmaslaney] ([e-mail])]

I agree, let's make the buttons full width.

Comment 5

[Potch [:potch]]

I'll try to detect button overflow and make them full width.

Comment 6

[Davor Spasovski [:spasovski]]

done: https://github.com/mozilla/fireplace/commit/1f14086