846539 - IonMonkey: Remove jsop_call_inline()

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Sean Stangl [:sstangl]]

Attachment: patch

jsop_call_inline() largely duplicates the behavior of inlineScriptedCall(), for the purpose of being more amenable to inclusion in inlineScriptedCalls(). By making small changes around the callsite of inlineScriptedCalls(), we can standardize on invariants and reuse the existing code.

Normalizing invariants eliminates a lot of messiness for Bug 837312.

Passes jit-tests and runs Octane.

Comment 1

[Kannan Vijayan [:djvj]]

Comment on attachment 719713 [details] [diff] [review]
patch

Review of attachment 719713 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Comment 2

[Sean Stangl [:sstangl]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4d1bc6b9d1a

Comment 3

[Sean Stangl [:sstangl]]

Backed out for exciting warnings-as-errors that only reproduce on clang builds:
http://hg.mozilla.org/integration/mozilla-inbound/rev/f61a73af62dd

Comment 4

[Sean Stangl [:sstangl]]

"return NULL" => "return false":
https://hg.mozilla.org/integration/mozilla-inbound/rev/36e5e8f66118

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/36e5e8f66118