Closed Bug 846615 Opened 7 years ago Closed 7 years ago

Valgrind warning about use after free in SocketAcceptTask

Categories

(Core :: DOM: Device Interfaces, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22
Tracking Status
firefox20 --- wontfix
firefox21 --- wontfix
firefox22 --- fixed
firefox-esr17 --- wontfix
b2g18 --- unaffected
b2g18-v1.0.0 --- unaffected
b2g18-v1.0.1 --- unaffected

People

(Reporter: bent.mozilla, Assigned: mrbkap)

References

Details

(Keywords: sec-high, Whiteboard: [adv-main22+])

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #845148 +++

I haven't run valgrind against m-c but I expect similar problems there.
It sounds like any problems found here will only be taken on trunk.  Marking sec-high on Ben's assumption that there will be similar badness.
Attached patch PatchSplinter Review
This has r=bent.

I know that it compiles, but I still need to push it to a phone and make sure that this works.
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #720941 - Flags: review+
Hi Eric, from what qDot tells me, it's impossible to test bluetooth on mozilla-central even without this patch. Would you mind taking over getting this patch in the tree and possibly rolling it up into the larger effort for bug 846586?
Assignee: mrbkap → echou
No longer blocks: 841925
Attached patch Bonus patchSplinter Review
I realized that a bunch of this stuff is no longer needed. One of the patches on trunk made it so that we no longer post UnixSocket events to the IO thread from the IO thread, simplifying things greatly. With this patch, mShuttingDownIOThread is only used in debug code for assertions, but it still might be useful, so I'm leaving it.
Attachment #720946 - Flags: review?(bent.mozilla)
Attachment #720946 - Flags: review?(bent.mozilla) → review+
(In reply to Blake Kaplan (:mrbkap) from comment #3)
> Hi Eric, from what qDot tells me, it's impossible to test bluetooth on
> mozilla-central even without this patch. Would you mind taking over getting
> this patch in the tree and possibly rolling it up into the larger effort for
> bug 846586?

Sure, I'll do it.

In addition, we also need to check in patches for bug 836715, bug 841576 and bug 841984. m-c debug build can't work normally without these patches either.
https://hg.mozilla.org/mozilla-central/rev/88517161a93d
https://hg.mozilla.org/mozilla-central/rev/d5ed7f560d5f
Assignee: echou → mrbkap
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Whiteboard: [adv-main22+]
Group: core-security
You need to log in before you can comment on or make changes to this bug.