846615 - Valgrind warning about use after free in SocketAcceptTask

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

+++ This bug was initially created as a clone of Bug #845148 +++

I haven't run valgrind against m-c but I expect similar problems there.

Comment 1

[Andrew McCreight [:mccr8]]

It sounds like any problems found here will only be taken on trunk.  Marking sec-high on Ben's assumption that there will be similar badness.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Patch

This has r=bent.

I know that it compiles, but I still need to push it to a phone and make sure that this works.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Hi Eric, from what qDot tells me, it's impossible to test bluetooth on mozilla-central even without this patch. Would you mind taking over getting this patch in the tree and possibly rolling it up into the larger effort for bug 846586?

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bonus patch

I realized that a bunch of this stuff is no longer needed. One of the patches on trunk made it so that we no longer post UnixSocket events to the IO thread from the IO thread, simplifying things greatly. With this patch, mShuttingDownIOThread is only used in debug code for assertions, but it still might be useful, so I'm leaving it.

Comment 5

[Eric Chou [:ericchou] [:echou]]

(In reply to Blake Kaplan (:mrbkap) from comment #3)
> Hi Eric, from what qDot tells me, it's impossible to test bluetooth on
> mozilla-central even without this patch. Would you mind taking over getting
> this patch in the tree and possibly rolling it up into the larger effort for
> bug 846586?

Sure, I'll do it.

In addition, we also need to check in patches for bug 836715, bug 841576 and bug 841984. m-c debug build can't work normally without these patches either.

Comment 6

[Eric Chou [:ericchou] [:echou]]

try: https://tbpl.mozilla.org/?tree=Try&rev=019c50b815ec

Comment 7

[Eric Chou [:ericchou] [:echou]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d5ed7f560d5f
https://hg.mozilla.org/integration/mozilla-inbound/rev/88517161a93d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/88517161a93d
https://hg.mozilla.org/mozilla-central/rev/d5ed7f560d5f