Closed Bug 846752 Opened 8 years ago Closed 8 years ago

Port Bug 713846 (unified log handling) to SeaMonkey Buildbot, utilize statusDB

Categories

(SeaMonkey :: Release Engineering, defect, P2)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Assigned: ewong)

References

Details

(Whiteboard: [logs])

Attachments

(3 files, 2 obsolete files)

Bug 713846 implemented a newer (better) log handling/status codepath. Which also uses statusDB.

Since statusDB is needed for buildAPI we need to implement this for that.
Depends on: 846753
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #720209 - Flags: review?(bugspam.Callek)
Attachment #720210 - Flags: review?(bugspam.Callek)
storing this here for now... this is the DB schema
Comment on attachment 720209 [details] [diff] [review]
Buildbotcustom changes to unify log handling. (v1)

Review of attachment 720209 [details] [diff] [review]:
-----------------------------------------------------------------

::: bin/log_uploader.py
@@ +144,5 @@
> +
> +        if times and times[0]:
> +          logFile.write("========= Started %s (at %s) ==========\n" % (shortText, datetime.fromtimestamp(times[0])))
> +        else:
> +          logFile.write("========= Started %s ==========\n" % shortText)

nit: make this line "Skipped" instead of "Started" (to match current moco logs)

::: process/release.py
@@ -22,1 @@
>  reload(release.paths)

(rubber stamp this file, since we don't use it yet, so these changes should be good)
Attachment #720209 - Flags: review?(bugspam.Callek) → review+
Attachment #720209 - Attachment is obsolete: true
Attachment #726018 - Flags: review+
Comment on attachment 720210 [details] [diff] [review]
Buildbot configs changes for unified log handling. (v1)

Review of attachment 720210 [details] [diff] [review]:
-----------------------------------------------------------------

Lets give it a shot!

I created the postrun.cfg on our master, I suspect its right (if not we'll likely get errors, but hopefully ones we can cleanup well)

::: seamonkey/master-main.cfg
@@ +3,5 @@
>  
>  # Shorthand
>  c = BuildmasterConfig = {}
>  
> +import os

need to import sys as well

@@ +89,5 @@
> +for b in c['builders']:
> +    assert 'properties' in b, b
> +    assert 'branch' in b['properties'], b
> +    assert 'platform' in b['properties'], b
> +    assert 'product' in b['properties'], b

I don't know if this is ok here, or if we need to add it to master.cfg instead. Either way if its not ok here we'll not pass checkconfig! and then should move it to master.cfg
Attachment #720210 - Flags: review?(bugspam.Callek) → review+
Attachment #720210 - Attachment is obsolete: true
Attachment #726029 - Flags: review+
so, I messed up the json in postrun.cfg (added an extra closing bracket)

And then caught another error in py syntax, was just a type so pushed a fix:
http://hg.mozilla.org/build/buildbotcustom/rev/143dfb270a7d
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.