846815 - [socorro-crashstats] Selecting a crash signature leads to signature not found

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

1. go to https://crash-stats-django.mozilla.org/topcrasher/products/FennecAndroid/versions/22.0a1?days=7
2. select the first signature link :
https://crash-stats-django.mozilla.org/report/list?range_value=7&range_unit=days&date=2013-03-01&signature=java.lang.NoSuchMethodError%3A+android.util.SparseBooleanArray.clone+at+org.mozilla.gecko.widget.TwoWayView.cloneCheckStates%28TwoWayView.java%29&version=FennecAndroid%3A22.0a1

Expected: A crash signature
Actual: "There were no reports in the time period specified. Please choose a different time period or use advanced search to select a custom time period."

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Noticed that if I click on the link, the product ended up changing to Firefox in the drop down.  It looks like the product is wrong and that's why it can't find the signature.

Comment 2

[Robert Helmer [:rhelmer]]

Hmmm yeah passing &product=FennecAndroid works:

https://crash-stats-django.mozilla.org/report/list?range_value=7&range_unit=days&date=2013-03-01&signature=java.lang.NoSuchMethodError%3A+android.util.SparseBooleanArray.clone+at+org.mozilla.gecko.widget.TwoWayView.cloneCheckStates%28TwoWayView.java%29&version=FennecAndroid%3A22.0a1&product=FennecAndroid

Comment 3

[Robert Helmer [:rhelmer]]

The original version of this report could handle multiple product/versions, not sure we really want to support that (or if it even works in the old version). It looks like passing product param gives the right behavior here afaict anyway...

Comment 4

[Robert Helmer [:rhelmer]]

Discussed this w/ Kairo in irc - I am pretty sure that the behavior on prod is incorrect.

You can't really see it with this example since it's very product/version specific, but if you load this from prod:

https://crash-stats.mozilla.com/report/list?range_value=7&range_unit=days&date=2013-03-01&signature=mozilla%3A%3Adom%3A%3AXrayResolveNativeProperty%28JSContext*%2C%20JSObject*%2C%20mozilla%3A%3Adom%3A%3ANativePropertyHooks%20const*%2C%20mozilla%3A%3Adom%3A%3ADOMObjectType%2C%20JSObject*%2C%20int%2C%20JSPropertyDescriptor*%29&version=Firefox%3A22.0a1

You can see in the signature summary that many products and versions show up, even though "&version=Firefox:22.0a1" is in the URL.

To fix this bug I think we should:

1) pass &product= in the URL from anywhere it's linked e.g. topcrashers page
2) only show all product/versions if &version=product:version is *not* specified

In the case where &product= does not match &version=, we should set the product pulldown to whatever &product= says but show the data for &version=product:version (this is the most confusing part.

Comment 5

[Robert Helmer [:rhelmer]]

Hey lonnen, got a sec to r? https://github.com/mozilla/socorro-crashstats/pull/308

See comment 4 for context.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro-crashstats

https://github.com/mozilla/socorro-crashstats/commit/386bc70d85122fa9599bcad33acf134e9a261a78
fixes bug 846815 - always pass product to report/list page

https://github.com/mozilla/socorro-crashstats/commit/8bfd42472ad39eaea3a58b9510ab5fddaf582aad
Merge pull request #308 from rhelmer/bug846815-always-pass-product-to-reportlist

bug 846815 - always pass product to report/list page