Closed
Bug 846937
Opened 12 years ago
Closed 12 years ago
gfxQuartzImageSurface should implement GetSize
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: seth, Assigned: seth)
References
Details
Attachments
(1 file)
|
2.37 KB,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
gfxQuartzImageSurface does not implement GetSize, so you always get gfxASurface's default implementation's result: (-1, -1). This needs to be fixed.
|
||
Updated•12 years ago
|
Attachment #720171 -
Flags: review?(jmuizelaar) → review+
|
Assignee | |
Comment 2•12 years ago
|
||
Thanks for the review, Jeff.
I don't think we have to run this through try by itself, since AFAIK this code path doesn't get touched in a meaningful way with the existing code. Bug 846312 exercises this code thoroughly, so if the try jobs there are good, we can consider this patch to be fine too.
|
|
Assignee | |
Comment 3•12 years ago
|
||
The try jobs in bug 846312 are looking super great. Pushed to inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bd0bf7c02cf
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•