Closed Bug 847120 Opened 7 years ago Closed 7 years ago

Convert filter elements that implement nsIDOMSVGFilterPrimitiveStandardAttributes to WebIDL

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: dzbarsky, Assigned: dzbarsky)

References

Details

Attachments

(29 files, 3 obsolete files)

417.63 KB, patch
Ms2ger
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
402.16 KB, patch
Ms2ger
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
4.70 KB, patch
bzbarsky
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
218.39 KB, patch
Ms2ger
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
23.65 KB, patch
Ms2ger
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
44.29 KB, patch
Ms2ger
: review+
jwatt
: feedback+
dzbarsky
: checkin+
Details | Diff | Splinter Review
385.79 KB, patch
Ms2ger
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
15.19 KB, patch
Ms2ger
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
319.09 KB, patch
Ms2ger
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
21.55 KB, patch
Ms2ger
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
297.70 KB, patch
Ms2ger
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
23.93 KB, patch
Ms2ger
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
275.69 KB, patch
Ms2ger
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
26.16 KB, patch
Ms2ger
: review+
dzbarsky
: review+
Details | Diff | Splinter Review
238.42 KB, patch
Ms2ger
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
18.20 KB, patch
Ms2ger
: review+
dzbarsky
: checkin+
Details | Diff | Splinter Review
215.45 KB, patch
Ms2ger
: review+
Details | Diff | Splinter Review
25.13 KB, patch
Ms2ger
: review+
Details | Diff | Splinter Review
197.44 KB, patch
Ms2ger
: review+
Details | Diff | Splinter Review
15.31 KB, patch
Ms2ger
: review+
Details | Diff | Splinter Review
187.54 KB, patch
Ms2ger
: review+
Details | Diff | Splinter Review
21.78 KB, patch
Ms2ger
: review+
Details | Diff | Splinter Review
164.16 KB, patch
Ms2ger
: review+
Details | Diff | Splinter Review
33.35 KB, patch
Ms2ger
: review+
Details | Diff | Splinter Review
128.11 KB, patch
Ms2ger
: review+
Details | Diff | Splinter Review
21.32 KB, patch
Ms2ger
: review+
Details | Diff | Splinter Review
105.82 KB, patch
Ms2ger
: review+
Details | Diff | Splinter Review
24.82 KB, patch
Ms2ger
: review+
Details | Diff | Splinter Review
8.97 KB, patch
Ms2ger
: review+
jwatt
: feedback+
Details | Diff | Splinter Review
No description provided.
Blocks: 832155
Attachment #720479 - Flags: review?(Ms2ger)
Attachment #720485 - Flags: review?(Ms2ger)
Comment on attachment 720479 [details] [diff] [review]
SVGFEMergeElement

Review of attachment 720479 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/nsSVGFilters.cpp
@@ +30,5 @@
>  
> +NS_INTERFACE_TABLE_HEAD(SVGFEMergeElement)
> +  NS_NODE_INTERFACE_TABLE3(SVGFEMergeElement, nsIDOMNode, nsIDOMElement,
> +                           nsIDOMSVGElement)
> +NS_INTERFACE_MAP_END_INHERITING(SVGFEMergeElementBase)

NS_IMPL_ISUPPORTS_INHERITED3

@@ +30,5 @@
>  
> +NS_INTERFACE_TABLE_HEAD(SVGFEMergeElement)
> +  NS_NODE_INTERFACE_TABLE3(SVGFEMergeElement, nsIDOMNode, nsIDOMElement,
> +                           nsIDOMSVGElement)
> +NS_INTERFACE_MAP_END_INHERITING(SVGFEMergeElementBase)

{}s get their own line for the constructor
Attachment #720479 - Flags: review?(Ms2ger) → review+
Comment on attachment 720485 [details] [diff] [review]
SVGFEFloodElement

Review of attachment 720485 [details] [diff] [review]:
-----------------------------------------------------------------

Same comments.

For future reference, it would be nice to have one patch that *just* splits out the classes into their own file, and one that does the renaming/WebIDL stuff.

::: content/svg/content/src/nsSVGFilters.cpp
@@ -2205,5 @@
> -public:
> -  virtual bool SubregionIsUnionOfRegions() { return false; }
> -
> -  // interfaces:
> -  NS_DECL_ISUPPORTS_INHERITED

Did you lose

virtual bool SubregionIsUnionOfRegions() { return false; }

?
Attachment #720485 - Flags: review?(Ms2ger) → review+
I think extending IsNodeOfType so that we have an eFilter (c.f. eAnimation) would be better than having a separate IsFilterElement method.
Using IsNodeOfType.
Attachment #720480 - Attachment is obsolete: true
Attachment #720480 - Flags: review?(jwatt)
Attachment #721012 - Flags: review?(jwatt)
Attachment #721586 - Flags: review?(Ms2ger)
Attachment #721587 - Flags: review?(Ms2ger)
Attachment #721588 - Flags: review?(Ms2ger)
Attached patch Move FETileSplinter Review
Attachment #721592 - Flags: review?(Ms2ger)
Attachment #721593 - Flags: review?(Ms2ger)
Comment on attachment 721586 [details] [diff] [review]
Move SVGFEImageElement

Review of attachment 721586 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, this was a *lot* easier to review.
Attachment #721586 - Flags: review?(Ms2ger) → review+
Comment on attachment 721587 [details] [diff] [review]
WebIDL API for FEImage

Review of attachment 721587 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGFEImageElement.cpp
@@ +15,5 @@
>  namespace mozilla {
>  namespace dom {
>  
> +JSObject*
> +SVGFEImageElement::WrapNode(JSContext *aCx, JSObject *aScope, bool *aTriedToWrap)

* to the left

@@ +40,3 @@
>                             imgINotificationObserver, nsIImageLoadingContent,
>                             imgIOnloadBlocker)
> +NS_INTERFACE_MAP_END_INHERITING(SVGFEImageElementBase)

NS_IMPL_ISUPPORTS_INHERITED7

@@ +284,5 @@
> +SVGFEImageElement::PreserveAspectRatio()
> +{
> +  nsRefPtr<DOMSVGAnimatedPreserveAspectRatio> ratio;
> +  mPreserveAspectRatio.ToDOMAnimatedPreserveAspectRatio(getter_AddRefs(ratio), this);
> +  return ratio.forget();

I'd r+ a better signature here
Attachment #721587 - Flags: review?(Ms2ger) → review+
Comment on attachment 721012 [details] [diff] [review]
Stop QIing to nsIDOMSVGFilterPrimitiveStandardAttributes

r=me
Attachment #721012 - Flags: review?(jwatt) → review+
Whiteboard: [leave open]
Attachment #721012 - Flags: checkin+
Wrong bug number in commit message, so backed out and relanded the FEBlend patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/9b7c6a46f1f6
Attachment #720479 - Flags: checkin+
Attachment #720485 - Flags: checkin+
Attachment #721586 - Flags: checkin+
Attachment #721587 - Flags: checkin+
Comment on attachment 721588 [details] [diff] [review]
Remove nsIDOMSVGURIReference

Review of attachment 721588 [details] [diff] [review]:
-----------------------------------------------------------------

Good riddance, but I'd like an SVG kind of guy to sign off on it :)
Attachment #721588 - Flags: superreview?(jwatt)
Attachment #721588 - Flags: review?(Ms2ger)
Attachment #721588 - Flags: review+
Attachment #721592 - Flags: review?(Ms2ger) → review+
Comment on attachment 721593 [details] [diff] [review]
WebIDL API for FETile

Review of attachment 721593 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGFETileElement.cpp
@@ +13,5 @@
>  namespace mozilla {
>  namespace dom {
>  
> +JSObject*
> +SVGFETileElement::WrapNode(JSContext *aCx, JSObject *aScope, bool *aTriedToWrap)

* to the left
Attachment #721593 - Flags: review?(Ms2ger) → review+
Attachment #721592 - Flags: checkin+
Attachment #721593 - Flags: checkin+
Backed out in http://hg.mozilla.org/integration/mozilla-inbound/rev/72952b8e3e81 because Windows builds were doing the horrible "Error while running startup cache precompilation" that usually means a crash on startup, no, you can't be told where it crashed, but also retriggered after a clobber, because I always suspect a need to clobber these days. If your second builds are fine, then just reland with yet another clobber set, and touch /CLOBBER so people will know to clobber their builds, too.
Comment on attachment 721588 [details] [diff] [review]
Remove nsIDOMSVGURIReference

I'm not a superreviewer, but here's f=jwatt instead.
Attachment #721588 - Flags: superreview?(jwatt) → feedback+
Attachment #721588 - Flags: checkin+
Attachment #726235 - Flags: review?(Ms2ger)
Attachment #726236 - Flags: review?(Ms2ger)
Attached patch Move FECompositeSplinter Review
Attachment #726237 - Flags: review?(Ms2ger)
Attachment #726238 - Flags: review?(Ms2ger)
Attachment #726236 - Attachment is patch: true
Attachment #726235 - Flags: review?(Ms2ger) → review+
Comment on attachment 726236 [details] [diff] [review]
WebIDL ColorMatrix

Review of attachment 726236 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGFEColorMatrixElement.cpp
@@ +56,3 @@
>  
> +NS_INTERFACE_TABLE_HEAD(SVGFEColorMatrixElement)
> +  NS_NODE_INTERFACE_TABLE3(SVGFEColorMatrixElement, nsIDOMNode, nsIDOMElement,

For nodes that use the new bindings, you don't need the _NODE_ part anymore. Just use the NS_IMPL_NSISUPPORTS_* macro instead?

@@ +86,3 @@
>  {
> +  return DOMSVGAnimatedNumberList::GetDOMWrapper(&mNumberListAttributes[VALUES],
> +                                                 this, VALUES).get();

Don't need the .get()

@@ +94,5 @@
>    aSources.AppendElement(nsSVGStringInfo(&mStringAttributes[IN1], this));
>  }
>  
>  nsresult
> +SVGFEColorMatrixElement::Filter(nsSVGFilterInstance *instance,

* to the left

::: content/svg/content/src/SVGFEColorMatrixElement.h
@@ +9,5 @@
> +#include "nsSVGEnum.h"
> +#include "nsSVGFilters.h"
> +#include "SVGAnimatedNumberList.h"
> +
> +typedef nsSVGFE SVGFEColorMatrixElementBase;

Move the typedef into the namespace if you drop the 'ns'?
Attachment #726236 - Flags: review?(Ms2ger) → review+
Attachment #726237 - Flags: review?(Ms2ger) → review+
Comment on attachment 726238 [details] [diff] [review]
WebIDL FEComposite

Review of attachment 726238 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGFECompositeElement.cpp
@@ +58,4 @@
>  
> +NS_INTERFACE_TABLE_HEAD(SVGFECompositeElement)
> +  NS_NODE_INTERFACE_TABLE3(SVGFECompositeElement, nsIDOMNode, nsIDOMElement,
> +                           nsIDOMSVGElement)

Same

@@ +121,4 @@
>  }
>  
>  nsresult
> +SVGFECompositeElement::Filter(nsSVGFilterInstance *instance,

* to the left
Attachment #726238 - Flags: review?(Ms2ger) → review+
(In reply to :Ms2ger from comment #33)
> Comment on attachment 726236 [details] [diff] [review]
> WebIDL ColorMatrix
> 
> Review of attachment 726236 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/svg/content/src/SVGFEColorMatrixElement.cpp
> @@ +56,3 @@
> >  
> > +NS_INTERFACE_TABLE_HEAD(SVGFEColorMatrixElement)
> > +  NS_NODE_INTERFACE_TABLE3(SVGFEColorMatrixElement, nsIDOMNode, nsIDOMElement,
> 
> For nodes that use the new bindings, you don't need the _NODE_ part anymore.
> Just use the NS_IMPL_NSISUPPORTS_* macro instead?
> 

Actually there's no point in even having this macro or declaring nsISupports. When I finish moving all the filter elements I'm going to make nsSVGElement implement nsIDOMSVGElement and stop declaring nsISupports in all the subclasses, so I'll just change this then.
Attachment #726235 - Flags: checkin+
Attachment #726236 - Flags: checkin+
Attachment #726237 - Flags: checkin+
Attachment #726238 - Flags: checkin+
Attachment #726478 - Flags: review?(Ms2ger)
Attached patch Convert FEGaussianBlur (obsolete) — Splinter Review
Attachment #726479 - Flags: review?(Ms2ger)
Attachment #726478 - Flags: review?(Ms2ger) → review+
Comment on attachment 726479 [details] [diff] [review]
Convert FEGaussianBlur

Patch is empty.
Attachment #726479 - Flags: review?(Ms2ger) → review-
Weird that the other one was empty...
Attachment #726479 - Attachment is obsolete: true
Attachment #726751 - Flags: review?(Ms2ger)
Comment on attachment 726751 [details] [diff] [review]
Convert FEGaussianBlur

Review of attachment 726751 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGFEGaussianBlurElement.cpp
@@ +241,5 @@
>  }
>  
>  void
> +SVGFEGaussianBlurElement::GaussianBlur(const Image *aSource,
> +                                       const Image *aTarget,

* to the left
Attachment #726751 - Flags: review?(Ms2ger) → review+
Attached patch Move FEOffsetSplinter Review
Attachment #727039 - Flags: review?(Ms2ger)
Attached patch Convert FEOffset (obsolete) — Splinter Review
Attachment #727040 - Flags: review?(Ms2ger)
Attachment #726478 - Flags: checkin+
Attachment #726751 - Flags: review+
Attached patch Convert FEOffsetSplinter Review
Attachment #727040 - Attachment is obsolete: true
Attachment #727040 - Flags: review?(Ms2ger)
Attachment #727055 - Flags: review?(Ms2ger)
Comment on attachment 727039 [details] [diff] [review]
Move FEOffset

Review of attachment 727039 [details] [diff] [review]:
-----------------------------------------------------------------

Are you missing the Makefile changes here?
(In reply to :Ms2ger from comment #47)
> Comment on attachment 727039 [details] [diff] [review]
> Move FEOffset
> 
> Review of attachment 727039 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Are you missing the Makefile changes here?

Yes, I forgot them.  They're in the other patch.
Comment on attachment 727039 [details] [diff] [review]
Move FEOffset

Review of attachment 727039 [details] [diff] [review]:
-----------------------------------------------------------------

r=me if you make the makefile changes in this patch.
Attachment #727039 - Flags: review?(Ms2ger) → review+
Attachment #727055 - Flags: review?(Ms2ger) → review+
Attachment #727039 - Flags: checkin+
Attachment #727055 - Flags: checkin+
Attachment #728452 - Flags: review?(Ms2ger)
Attachment #728453 - Flags: review?(Ms2ger)
Attachment #728454 - Flags: review?(Ms2ger)
Attachment #728469 - Flags: review?(Ms2ger)
Attachment #728506 - Flags: review?(Ms2ger)
Attachment #728508 - Flags: review?(Ms2ger)
Attachment #728506 - Attachment description: Move FEDiffuseMap → Move FEDisplacementMap
Attachment #728578 - Flags: review?(Ms2ger)
Attachment #728579 - Flags: review?(Ms2ger)
Attachment #728580 - Flags: review?(Ms2ger)
Attachment #728581 - Flags: review?(Ms2ger)
Attachment #728582 - Flags: review?(Ms2ger)
Attachment #728583 - Flags: review?(Ms2ger)
Attachment #728452 - Flags: review?(Ms2ger) → review+
Comment on attachment 728453 [details] [diff] [review]
Convert FESpecularLighting

Review of attachment 728453 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGFESpecularLightingElement.cpp
@@ +9,2 @@
>  
> +NS_IMPL_NS_NEW_NAMESPACED_SVG_ELEMENT(FESpecularLighting)

Can you file a followup to make sure we remove the old one at some point?

@@ +65,1 @@
>                                                                         this);

Maybe

  return mNumberPairAttributes[KERNEL_UNIT_LENGTH].ToDOMAnimatedNumber(
    nsSVGNumberPair::eFirst, this);

to avoid the 80-columns limit.

@@ +70,2 @@
>  {
> +  return mNumberPairAttributes[KERNEL_UNIT_LENGTH].ToDOMAnimatedNumber(nsSVGNumberPair::eSecond,

Same here

@@ +75,5 @@
>  //----------------------------------------------------------------------
>  // nsSVGElement methods
>  
>  nsresult
> +SVGFESpecularLightingElement::Filter(nsSVGFilterInstance *instance,

* to the left

::: content/svg/content/src/nsSVGFilters.cpp
@@ -2042,5 @@
> -//------------------------------------------------------------
> -
> -typedef nsSVGFE nsSVGFELightingElementBase;
> -
> -class nsSVGFELightingElement : public nsSVGFELightingElementBase

I'm pretty sure this doesn't belong here.

::: content/svg/content/src/nsSVGFilters.h
@@ +22,5 @@
>  class nsSVGFilterResource;
>  class nsSVGNumberPair;
>  
> +#define DOT(a,b) (a[0] * b[0] + a[1] * b[1] + a[2] * b[2])
> +#define NORMALIZE(vec) \

Making those two inline functions would make me happy.
Attachment #728453 - Flags: review?(Ms2ger) → review+
Attachment #728454 - Flags: review?(Ms2ger) → review+
Comment on attachment 728469 [details] [diff] [review]
Convert FEDiffuseLighting

Review of attachment 728469 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGFEDiffuseLightingElement.cpp
@@ +58,2 @@
>  {
> +  return mNumberPairAttributes[KERNEL_UNIT_LENGTH].ToDOMAnimatedNumber(nsSVGNumberPair::eFirst,

As before
Attachment #728469 - Flags: review?(Ms2ger) → review+
Comment on attachment 728506 [details] [diff] [review]
Move FEDisplacementMap

Review of attachment 728506 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGFEDiffuseLightingElement.cpp
@@ +4,5 @@
>   * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
>  
>  #include "mozilla/dom/SVGFEDiffuseLightingElement.h"
>  #include "mozilla/dom/SVGFEDiffuseLightingElementBinding.h"
> +#include "nsSVGUtils.h"

This doesn't belong here.
Attachment #728506 - Flags: review?(Ms2ger) → review+
Attachment #728508 - Flags: review?(Ms2ger) → review+
Attachment #728578 - Flags: review?(Ms2ger) → review+
Comment on attachment 728579 [details] [diff] [review]
Convert FEConvolveMatrix

Review of attachment 728579 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGFEConvolveMatrixElement.cpp
@@ +120,2 @@
>  {
> +  return DOMSVGAnimatedNumberList::GetDOMWrapper(&mNumberListAttributes[KERNELMATRIX],

Hmm, why does this have a different interface than all the others? Maybe file a bug.

::: content/svg/content/src/nsSVGBoolean.cpp
@@ +104,5 @@
>    aSVGElement->DidAnimateBoolean(mAttrEnum);
>  }
>  
> +already_AddRefed<SVGAnimatedBoolean>
> +nsSVGBoolean::ToDOMAnimatedBoolean(nsSVGElement *aSVGElement)

* to the left
Attachment #728579 - Flags: review?(Ms2ger) → review+
Attachment #728580 - Flags: review?(Ms2ger) → review+
Attachment #728581 - Flags: review?(Ms2ger) → review+
Attachment #728582 - Flags: review?(Ms2ger) → review+
Comment on attachment 728583 [details] [diff] [review]
Convert FETurbulence

Review of attachment 728583 [details] [diff] [review]:
-----------------------------------------------------------------

Sometimes I accidentally look at the interface you're dealing with and I wonder if the SVG WG was on crack...
Attachment #728583 - Flags: review?(Ms2ger) → review+
Comment on attachment 728584 [details] [diff] [review]
Remove nsIDOMSVGFilterPrimitiveStandardAttributes

Review of attachment 728584 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/interfaces/svg/nsIDOMSVGFilters.idl
@@ -1,3 @@
> -/* -*- Mode: IDL; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
> -/* This Source Code Form is subject to the terms of the Mozilla Public
> - * License, v. 2.0. If a copy of the MPL was not distributed with this

\o/ \o/ \o/ \o/ \o/ \o/ \o/
Attachment #728584 - Flags: review?(Ms2ger)
Attachment #728584 - Flags: review+
Attachment #728584 - Flags: feedback?(jwatt)
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [leave open]
(In reply to :Ms2ger from comment #66)
> Comment on attachment 728453 [details] [diff] [review]
> Convert FESpecularLighting
> 
> Review of attachment 728453 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: content/svg/content/src/SVGFESpecularLightingElement.cpp
> @@ +9,2 @@
> >  
> > +NS_IMPL_NS_NEW_NAMESPACED_SVG_ELEMENT(FESpecularLighting)
> 
> Can you file a followup to make sure we remove the old one at some point?
> 
> @@ +65,1 @@
> >                                                                         this);
> 
> Maybe
> 
>   return mNumberPairAttributes[KERNEL_UNIT_LENGTH].ToDOMAnimatedNumber(
>     nsSVGNumberPair::eFirst, this);
> 
> to avoid the 80-columns limit.
> 
> @@ +70,2 @@
> >  {
> > +  return mNumberPairAttributes[KERNEL_UNIT_LENGTH].ToDOMAnimatedNumber(nsSVGNumberPair::eSecond,
> 
> Same here
> 
> @@ +75,5 @@
> >  //----------------------------------------------------------------------
> >  // nsSVGElement methods
> >  
> >  nsresult
> > +SVGFESpecularLightingElement::Filter(nsSVGFilterInstance *instance,
> 
> * to the left
> 
> ::: content/svg/content/src/nsSVGFilters.cpp
> @@ -2042,5 @@
> > -//------------------------------------------------------------
> > -
> > -typedef nsSVGFE nsSVGFELightingElementBase;
> > -
> > -class nsSVGFELightingElement : public nsSVGFELightingElementBase
> 
> I'm pretty sure this doesn't belong here.

We need that because SpecularLighting inherits from it.  I can file a followup to move it somewhere else if you want.

> ::: content/svg/content/src/nsSVGFilters.h
> @@ +22,5 @@
> >  class nsSVGFilterResource;
> >  class nsSVGNumberPair;
> >  
> > +#define DOT(a,b) (a[0] * b[0] + a[1] * b[1] + a[2] * b[2])
> > +#define NORMALIZE(vec) \
> 
> Making those two inline functions would make me happy.
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/a3aef14dc53a because something in the push caused, precipitated, whatever, bug 854225.
Depends on: 854225
Attachment #728584 - Flags: feedback?(jwatt) → feedback+
https://hg.mozilla.org/mozilla-central/rev/54e4bbd35f15
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Depends on: 935902
You need to log in before you can comment on or make changes to this bug.