Closed
Bug 832155
Opened 11 years ago
Closed 11 years ago
Convert SVG filter elements to WebIDL
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: dzbarsky, Assigned: dzbarsky)
References
Details
Attachments
(4 files)
350.71 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
16.68 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
343.02 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
13.02 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #721594 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #721595 -
Flags: review?(Ms2ger)
Updated•11 years ago
|
Attachment #721594 -
Flags: review?(Ms2ger) → review+
Comment 3•11 years ago
|
||
Comment on attachment 721595 [details] [diff] [review] WebIDL API for PointLight Review of attachment 721595 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/svg/content/src/SVGFEPointLightElement.cpp @@ +11,5 @@ > namespace mozilla { > namespace dom { > > +JSObject* > +SVGFEPointLightElement::WrapNode(JSContext *aCx, JSObject *aScope, bool *aTriedToWrap) * to the left ::: content/svg/content/src/SVGFEPointLightElement.h @@ +27,5 @@ > + : SVGFEPointLightElementBase(aNodeInfo) > + { > + SetIsDOMBinding(); > + } > + virtual JSObject* WrapNode(JSContext *cx, JSObject *scope, bool *triedToWrap) MOZ_OVERRIDE; * to the left and aFoo ::: content/svg/content/src/nsSVGFilters.cpp @@ +3333,5 @@ > aVal = std::max(aVal, 0); > return std::min(aVal, aMax - 1); > } > > +static int32_t WrapInterval(int32_t aVal, int32_t aMax) Was this broken in the previous patch?
Attachment #721595 -
Flags: review?(Ms2ger) → review+
Assignee | ||
Comment 4•11 years ago
|
||
(In reply to :Ms2ger from comment #3) > > Was this broken in the previous patch? This part got deleted in a different patch. remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/74ff58a4b51d remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/36094d21286a
Whiteboard: [leave open]
Assignee | ||
Comment 5•11 years ago
|
||
Attachment #724625 -
Flags: review?(Ms2ger)
Assignee | ||
Comment 6•11 years ago
|
||
Attachment #724626 -
Flags: review?(Ms2ger)
Assignee | ||
Updated•11 years ago
|
Attachment #724626 -
Attachment is patch: true
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/74ff58a4b51d https://hg.mozilla.org/mozilla-central/rev/36094d21286a
Updated•11 years ago
|
Attachment #724625 -
Flags: review?(Ms2ger) → review+
Comment 8•11 years ago
|
||
Comment on attachment 724626 [details] [diff] [review] WebIDL API for FEDistantLight Review of attachment 724626 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/svg/content/src/SVGFEDistantLightElement.cpp @@ +11,5 @@ > +namespace mozilla { > +namespace dom { > + > +JSObject* > +SVGFEDistantLightElement::WrapNode(JSContext *aCx, JSObject *aScope, bool *aTriedToWrap) * to the left @@ +66,5 @@ > +//---------------------------------------------------------------------- > +// nsSVGElement methods > + > +nsSVGElement::NumberAttributesInfo > +SVGFEDistantLightElement::GetNumberInfo() Just don't remove this in the previous patch.
Attachment #724626 -
Flags: review?(Ms2ger) → review+
Assignee | ||
Comment 9•11 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/11a2ae73e705 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/9606fa13b8e3
Assignee | ||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/88ca40b7feeb
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/11a2ae73e705 https://hg.mozilla.org/mozilla-central/rev/9606fa13b8e3 https://hg.mozilla.org/mozilla-central/rev/88ca40b7feeb
Assignee | ||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
You need to log in
before you can comment on or make changes to this bug.
Description
•