Closed Bug 832155 Opened 7 years ago Closed 7 years ago

Convert SVG filter elements to WebIDL

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dzbarsky, Assigned: dzbarsky)

References

Details

Attachments

(4 files)

No description provided.
Depends on: 835065
Depends on: 837044
Depends on: 847116
Depends on: 847120
Depends on: 847202
Attachment #721594 - Flags: review?(Ms2ger)
Attachment #721595 - Flags: review?(Ms2ger)
Depends on: 849710
Attachment #721594 - Flags: review?(Ms2ger) → review+
Comment on attachment 721595 [details] [diff] [review]
WebIDL API for PointLight

Review of attachment 721595 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGFEPointLightElement.cpp
@@ +11,5 @@
>  namespace mozilla {
>  namespace dom {
>  
> +JSObject*
> +SVGFEPointLightElement::WrapNode(JSContext *aCx, JSObject *aScope, bool *aTriedToWrap)

* to the left

::: content/svg/content/src/SVGFEPointLightElement.h
@@ +27,5 @@
> +    : SVGFEPointLightElementBase(aNodeInfo)
> +  {
> +    SetIsDOMBinding();
> +  }
> +  virtual JSObject* WrapNode(JSContext *cx, JSObject *scope, bool *triedToWrap) MOZ_OVERRIDE;

* to the left and aFoo

::: content/svg/content/src/nsSVGFilters.cpp
@@ +3333,5 @@
>    aVal = std::max(aVal, 0);
>    return std::min(aVal, aMax - 1);
>  }
>  
> +static int32_t WrapInterval(int32_t aVal, int32_t aMax)

Was this broken in the previous patch?
Attachment #721595 - Flags: review?(Ms2ger) → review+
(In reply to :Ms2ger from comment #3)
> 
> Was this broken in the previous patch?

This part got deleted in a different patch.

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/74ff58a4b51d
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/36094d21286a
Whiteboard: [leave open]
Attachment #724625 - Flags: review?(Ms2ger)
Attachment #724626 - Flags: review?(Ms2ger)
Attachment #724626 - Attachment is patch: true
Attachment #724625 - Flags: review?(Ms2ger) → review+
Comment on attachment 724626 [details] [diff] [review]
WebIDL API for FEDistantLight

Review of attachment 724626 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/svg/content/src/SVGFEDistantLightElement.cpp
@@ +11,5 @@
> +namespace mozilla {
> +namespace dom {
> +
> +JSObject*
> +SVGFEDistantLightElement::WrapNode(JSContext *aCx, JSObject *aScope, bool *aTriedToWrap)

* to the left

@@ +66,5 @@
> +//----------------------------------------------------------------------
> +// nsSVGElement methods
> +
> +nsSVGElement::NumberAttributesInfo
> +SVGFEDistantLightElement::GetNumberInfo()

Just don't remove this in the previous patch.
Attachment #724626 - Flags: review?(Ms2ger) → review+
Depends on: 851954
Depends on: 851972
Depends on: 853692
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [leave open]
You need to log in before you can comment on or make changes to this bug.