84720 - [MLK] Leaking JSScopeProperty objects

Status: VERIFIED DUPLICATE of bug 90597

(Core :: JavaScript Engine, defect)

Description

[Patrick C. Beard]

Take a look at the enclosed leak report the Boehm GC leak detector detects the 
leaking of two JSScopeProperty objects. Perhaps the stack crawls can provide some 
context. This leak was detected with a tip pull from late evening 7-June-2001.

Comment 1

[Patrick C. Beard]

Attachment: Leak report

Comment 2

[Brendan Eich [:brendan]]

Wow, someone leaks a C++ object that holds a JS GC root, which leaks one or more
JS objects, which own their scopes, which own their JSScopeProperty structs.  No
news here.  This is probably a dup of a bug dbaron knows about.  To be sure, run
with use GC_MARK_DEBUG and root dumping to show that a root keeps alive the
object whose scope owns these JSScopeProperties.

/be

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It's not a bug I know about.  How'd you get it to leak?

Comment 4

[Patrick C. Beard]

If you look at the report, these are root leaks, meaning no other leaking objects 
in the heap reference them. So, there may be a trivial leak lurking, smashing/
overwriting a pointer. I just ran the browser from a build I created this 
morning. I did have some strange skin settings that cleared up when I chose 
modern or classic. I keep my startup page blank, so I wasn't visiting any 
particular site. I'll let you know if the leak is reproducible.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

They *may* be root leaks.  However, my experience with the JS engine is that
when we leak a GC root it cleans up some things but not others, so there's an
appearance that there are tons of root leaks (of various types) when there
really aren't.

However, if it were only this single type of object that was leaked, I'd be more
inclined to think it might be a leak in the JS engine.

Was this an excerpt from a leak report or the whole thing?

Comment 6

[Patrick C. Beard]

An excerpt, but nothing else appeared to come from the JS engine.

Comment 7

[Brendan Eich [:brendan]]

Sorry, I forgot about this bug when bug 90597 came along and got fixed.

/be

*** This bug has been marked as a duplicate of 90597 ***

Comment 8

[Phil Schwartau]

Marking Verified Duplicate -