847256 - UnicodeEncodeError: 'ascii' codec can't encode character when running TBPL marionette tests

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

When running try server for B2G marionette tests (Bug 797296), we met one UnicodeEncodeError, see [1], and 
This test script will run some tests to verify the decoding of the raw PDU so some of them will be Japanese or Chinese characters.

We ran these tests well on our PCs however it failed in TBPL.
So it seems TBPL cannot accept characters encoded in Japanese or Chinese.


[1]: https://tbpl.mozilla.org/?tree=Try&rev=15684a551bbc

Comment 1

[Jonathan Griffin (:jgriffin)]

The error's stack trace is:

02:49:39     INFO -    File "/home/cltbld/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 137, in run
02:49:39     INFO -      result.printLogs(test)
02:49:39     INFO -    File "/home/cltbld/talos-slave/test/build/tests/marionette/marionette/runtests.py", line 68, in printLogs
02:49:39     INFO -      self.stream.writeln(' '.join(line))
02:49:39     INFO -    File "/usr/lib/python2.6/unittest.py", line 665, in writeln
02:49:39     INFO -      if arg: self.write(arg)
02:49:39     INFO -  UnicodeEncodeError: 'ascii' codec can't encode character u'\u30eb' in position 131: ordinal not in range(128)

Comment 2

[Jonathan Griffin (:jgriffin)]

Attachment: Handle non-ascii chars in log data

Can you see if this patch fixes the problem?

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

We have tried but currently TPBL met errors from Bug 847683,
will try your patch again once it's fixed.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi, Griffin
The patch seems okay, now the TPBL passed, without complaining EncodeError.

https://tbpl.mozilla.org/?tree=Try&rev=42ea5b7953b6

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 720948 [details] [diff] [review]
Handle non-ascii chars in log data

Seems Griffin is not around,
I sent r? to mdas on Griffin's behalf.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

ping? Griffin and Das?

Comment 7

[Malini Das [:mdas] - Away, not checking bugmail]

Comment on attachment 720948 [details] [diff] [review]
Handle non-ascii chars in log data

Review of attachment 720948 [details] [diff] [review]:
-----------------------------------------------------------------

My apologies, my patch review queue is a bit backed up. I'll land it in m-i/m-c

Comment 8

[Malini Das [:mdas] - Away, not checking bugmail]

landing on m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1538a45f97b

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Thank you :)

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e1538a45f97b

Comment 11

[Malini Das [:mdas] - Away, not checking bugmail]

https://hg.mozilla.org/releases/mozilla-b2g18/pushloghtml?changeset=71f7f42dee13

Comment 12

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/47b7c34f4c8b