Closed
Bug 847308
Opened 13 years ago
Closed 13 years ago
Friends_list.js is buggy with hotmail contacts
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:leo+, b2g18 fixed)
People
(Reporter: jmcf, Assigned: crdlc)
References
Details
Attachments
(1 file)
This bug encompasses the following work:
Refactor friends_list.js to enable grouping / ordering by givenName or family name. Making unnamed friends to appear correctly.
Ideally there should be a unique 'contacts_list_render.js' file shared between Contacts and Import but this should be studied carefully.
|
Assignee | |
Updated•13 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•13 years ago
|
||
This patch implements a friend list renderer for all services like Facebook, Gmail and Live. It supports ordering by first and last name. And, moreover, does not render items without name and e-mail. It fixes the bug about ordering of groups (A..Z #).
Attachment #721719 -
Flags: review?(jmcf)
|
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 721719 [details]
Patch v1
good job. up, running and Travis build ok!
Attachment #721719 -
Flags: review?(jmcf) → review+
|
|
Reporter | |
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 4•13 years ago
|
||
this patch is necessary for Hotmail & Gmail import, thus it should be leo+
blocking-b2g: --- → leo?
|
|
||
Updated•13 years ago
|
blocking-b2g: leo? → leo+
|
|
||
Comment 5•13 years ago
|
||
Uplifted commit d4e583ee03650279abba276cde9e93195ac6074e as:
v1-train: e5ed5bb408bf680128381bee0bdb8841e5846f18
status-b2g18:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•