847451 - add win8 to the wait times email

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Armen [:armenzg]]

We send every day an email to tree-management [1] which contains how much each job had to wait before a machine could process them.

We should add win8 to this report. An example of this would be this:
https://bug741444.bugzilla.mozilla.org/attachment.cgi?id=611514

The code lives in here:
http://hg.mozilla.org/build/buildapi

This bug has no rush until we have the win8 test jobs running everywhere.

We have to check with joduinn first before we could enable this since he is trying to analyze what improvements we cause by moving jobs to AWS on the Linux realm.

[1] https://groups.google.com/forum/?fromgroups=#!topic/mozilla.dev.tree-management/nQoaOf9jZN4

Comment 1

[Armen [:armenzg]]

> We have to check with joduinn first before we could enable this since he is
> trying to analyze what improvements we cause by moving jobs to AWS on the
> Linux realm.

I spoke with joduinn and we can go ahead and work on this.

Comment 2

[Carsten Book [:Tomcat]]

Attachment: 1st try

hey armen, so something like this?

Comment 3

[Armen [:armenzg]]

Comment on attachment 723879 [details] [diff] [review]
1st try

Review of attachment 723879 [details] [diff] [review]:
-----------------------------------------------------------------

Can you please post a new patch? I will review it right away.

::: buildapi/model/util.py
@@ +86,5 @@
>          re.compile('jetpack-.*-w764'),
>      ],
> +    'win8': [
> +        re.compile('^Rev3 WINNT 6\.2 '),
> +        re.compile('.*-win8.*'),

No need for this last line. Other platforms have more things to match like jetpack jobs on win764 but we don't have the same situation for win8.

@@ +91,5 @@
> +    ],
> +    'win864': [
> +        re.compile('^WINNT 6\.2 x64 .+'),
> +        re.compile('.*-w864.*'),
> +    ],    

Please remove this block.
No need for "win864" because we're only testing the 32-bit build rather than a 64-bit build (even though our host test machine is 64-bit).

Comment 4

[Carsten Book [:Tomcat]]

Attachment: patch

here we go:) thanks armen!

Comment 5

[Armen [:armenzg]]

Comment on attachment 723912 [details] [diff] [review]
patch

Review of attachment 723912 [details] [diff] [review]:
-----------------------------------------------------------------

That's correct!
Feel free to land. Can you also ask catlee how this change is made live?
I believe it runs on cruncher.
Once you figure out, could you also ask him under which wiki page we could document it? (if it is not already)

Thanks Tomcat!

::: buildapi/model/util.py
@@ +86,5 @@
>          re.compile('jetpack-.*-w764'),
>      ],
> +    'win8': [
> +        re.compile('^Rev3 WINNT 6\.2 '),
> +    ],    

Nit: can you please remove the extra white spaces in the last line?

Comment 6

[Carsten Book [:Tomcat]]

Attachment: updated patch

updated patch

Comment 7

[Carsten Book [:Tomcat]]

Comment on attachment 723919 [details] [diff] [review]
updated patch

checked in -> http://hg.mozilla.org/build/buildapi/rev/aea873742e52

Comment 8

[Armen [:armenzg]]

Attachment: more win8 wait times code

Hi catlee,
I have tried everything that I could think of to try to see win8 on the wait times report.

I have tried applying this patch and hope to see changes on:
https://secure.pub.build.mozilla.org/buildapi/reports/waittimes/testpool
Or be able to send a report to myself:
/home/buildapi/bin/python /home/buildapi/src/buildapi/scripts/mailwaittimes.py -p testpool -a <email_here>

I don't know what else to try.

Comment 9

[Armen [:armenzg]]

Comment on attachment 725043 [details] [diff] [review]
more win8 wait times code

I just tested that this works.
win8: 720
Wait Time	Number	Percentage
0	671	93.19%
15	49	6.81%