847586 - Paris binding for MutationEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=779cc0e2816d

Wanted to do a try: -a for the first webidl event on top of the base Event interface.

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 721317 [details] [diff] [review]
patch

Review of attachment 721317 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsDOMMutationEvent.h
@@ +49,5 @@
> +                         nsINode*& aRelatedNode,
> +                         const mozilla::dom::NonNull<nsAString>& aPrevValue,
> +                         const mozilla::dom::NonNull<nsAString_internal>& aNewValue,
> +                         const mozilla::dom::NonNull<nsAString_internal>& aAttrName,
> +                         uint16_t& aAttrChange, mozilla::ErrorResult& aRv)

Should just be

 void InitMutationEvent(const nsAString& aType,
                        bool aCanBubble, bool aCancelable,
                        nsINode* aRelatedNode,
                        const nsAString& aPrevValue,
                        const nsAString& aNewValue,
                        const nsAString& aAttrName,
                        uint16_t aAttrChange, mozilla::ErrorResult& aRv)

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Hmm, ok.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

https://tbpl.mozilla.org/?tree=Try&rev=ecfd4f0ee07d

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

(Could use AsDOMNode() instead of QI. But not big deal)

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 723123 [details] [diff] [review]
patch

Review of attachment 723123 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsDOMMutationEvent.cpp
@@ +42,5 @@
>  nsDOMMutationEvent::GetRelatedNode(nsIDOMNode** aRelatedNode)
>  {
> +  nsCOMPtr<nsINode> relatedNode = GetRelatedNode();
> +  nsCOMPtr<nsIDOMNode> relatedDOMNode = relatedNode ? relatedNode->AsDOMNode() : nullptr;
> +  relatedDOMNode.swap(*aRelatedNode);

relatedDOMNode.forget(aRelatedNode);

::: content/events/src/nsDOMMutationEvent.h
@@ +39,5 @@
> +
> +  already_AddRefed<nsINode> GetRelatedNode()
> +  {
> +    nsCOMPtr<nsINode> n =
> +      do_QueryInterface(static_cast<nsMutationEvent*>(mEvent)->mRelatedNode);

I'd ask for a followup to make mRelatedNode an nsINode, but meh, MutationEvent.

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 10

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ea13caf078a7

Comment 11

[Ed Morley [:emorley]]

Push backed out for crashes, eg:
https://tbpl.mozilla.org/php/getParsedLog.php?id=20644254&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20644682&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=20644913&tree=Mozilla-Inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/630d841daf46
https://hg.mozilla.org/integration/mozilla-inbound/rev/44810fa6c312
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f128f1af706

Comment 12

[Masatoshi Kimura [:emk]]

Comment on attachment 724855 [details] [diff] [review]
patch

>+
>+  virtual JSObject* WrapObject(JSContext* aCx, JSObject* aScope)

MOZ_OVERRIDE

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8c88ac65a81b

Comment 14

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/8c88ac65a81b