847596 - Paris binding for DeviceMotionEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

This is tiny bit painful with the current setup and binding behavior. But patch coming + 
some extra tests.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Not super-pretty, but wanted to keep the existing behavior
(which is not exactly what the spec has, but spec isn't too good either).
So, need to support both JS callback interfaces and natively implemented stuff.
Added some tests too.
https://tbpl.mozilla.org/?tree=Try&rev=04a89abd2958

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: less using namespace

Hopefully osx likes this
https://tbpl.mozilla.org/?tree=Try&rev=3b8b959c86c7

Comment 4

[Peter Van der Beken [:peterv]]

Comment on attachment 731454 [details] [diff] [review]
less using namespace

Review of attachment 731454 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsDOMDeviceMotionEvent.cpp
@@ +60,5 @@
> +                                              ErrorResult& aRv)
> +{
> +  nsresult rv = nsDOMEvent::InitEvent(aEventType, aCanBubble, aCancelable);
> +  aRv = rv;
> +  NS_ENSURE_SUCCESS_VOID(rv);

I think

  aRv = nsDOMEvent::InitEvent(aEventType, aCanBubble, aCancelable);
  if (aRv.Failed()) {
    return;
  }

is clearer.

::: dom/webidl/DeviceMotionEvent.webidl
@@ +17,5 @@
> +                             boolean canBubbleArg,
> +                             boolean cancelableArg,
> +                             DummyDeviceMotionCallback? acceleration,
> +                             DummyDeviceMotionCallback? accelerationIncludingGravity,
> +                             DummyDeviceMotionCallback? rotationRate,

Please make these be DeviceAcceleration/DeviceRotationRate and remove the DummyDeviceMotionCallback, it seems to work fine in my testing.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Attachment: using xpidl interfaces for init()

Something has changed since this seems to work now.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2d71598ee2ea

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2d71598ee2ea