847597 - Paris binding for NotifyAudioAvailableEvent

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: WIP

Need to get bug 856338 fixed first.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Not super nice, but hopefully we can get rid of this event once Audio API works well enough.

https://tbpl.mozilla.org/?tree=Try&rev=79e5a32df4b4

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 741040 [details] [diff] [review]
patch

Review of attachment 741040 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/events/src/nsDOMNotifyAudioAvailableEvent.cpp
@@ +143,5 @@
> +  }
> +
> +  nsAutoArrayPtr<float> buffer;
> +  if (!aFrameBuffer.IsNull()) {
> +    buffer = new float[aFrameBufferLength];

Hmm, don't we want this to be a fallible allocation? Seems like this could be controlled from script?

::: content/events/src/nsDOMNotifyAudioAvailableEvent.h
@@ +39,5 @@
>                                          float aTime);
>  
>    ~nsDOMNotifyAudioAvailableEvent();
>  
> +  virtual JSObject* WrapObject(JSContext* aCx, JSObject* aScope)

I suppose I should have commented about that in all the previous conversions :-/: MOZ_OVERRIDE.

::: dom/webidl/NotifyAudioAvailableEvent.webidl
@@ +6,5 @@
> +
> +interface NotifyAudioAvailableEvent : Event
> +{
> +  [Throws]
> +  readonly attribute any frameBuffer;

This really should return Float32Array.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Peter Van der Beken [:peterv] from comment #3)
> > +  [Throws]
> > +  readonly attribute any frameBuffer;
> 
> This really should return Float32Array.
But our current infrastructure for TypedArrays doesn't make it easy to cache the JS.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Ah, I was told the getter becomes JSObject*

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Float32Array, and removed qs

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fdc122c78f1d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fdc122c78f1d