VectorImage doesn't need to defer OnStopRequest anymore

RESOLVED FIXED in mozilla22

Status

()

Core
ImageLib
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: seth, Assigned: seth)

Tracking

Trunk
mozilla22
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Since bug 841579 landed, it should now be the case that things don't blow up if all decoding isn't complete by the time LOAD_COMPLETE is sent to nsImageLoadingContent. That means the code added for bug 704059 which deferred the arrival of OnStopRequest for VectorImages until the underlying document was ready is probably redundant now. Let's rip that out and keep things as simple as possible.
(Assignee)

Comment 1

5 years ago
Created attachment 723153 [details] [diff] [review]
Stop deferring OnStopRequest in VectorImage.

Proposed patch. Try job here: https://tbpl.mozilla.org/?tree=Try&rev=b920b9632166
(Assignee)

Comment 2

5 years ago
OK, nothing appears to have broken. Now for a broader test to see if we start hitting test_animSVGImage mochitest failures frequently again.

Try job here: https://tbpl.mozilla.org/?tree=Try&rev=ee66def6285b
(Assignee)

Comment 4

5 years ago
Ack, just realized that I never actually requested review for this, even though the patch says r=joe. Joe, I'm gonna go ahead and request review anyway; if you find any issues I'll just create a followup patch to fix them or back the patch out. Sorry for the screwup.
(Assignee)

Updated

5 years ago
Attachment #723153 - Flags: review?(joe)
Attachment #723153 - Flags: review?(joe) → review+
https://hg.mozilla.org/mozilla-central/rev/e2cdf49fe873
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Blocks: 850951
You need to log in before you can comment on or make changes to this bug.