84766 - [FIX]making history.dat readonly renders url bar inoperative

Status: RESOLVED FIXED

(SeaMonkey :: Location Bar, defect, P5)

Description

[gsa]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Macintosh; U; PPC; en-US; rv:0.9.1) Gecko/20010607
BuildID:    2001060712

I did a "get info" on the history.dat file and locked it so Mozilla can't write
to it. rebooted Mozilla. Now Url Bar doesn't work anymore.

Reproducible: Always
Steps to Reproduce:
1. select "history.dat" file in Mozilla profiles folder
2. using "get info" command lock it so it cannot be written to
3. reboot Mozilla, enter a url in the url bar and try to activate it

Actual Results:  Nothing happens

Expected Results:  url entered in the url bar should have activated

Comment 1

[Alec Flett]

nobody said that was supported :)
moving to future..

Comment 2

[gsa]

After checking the Javascript Console I found this error which resulted from
locking the history.dat file

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [nsIAutoCompleteSession.onStartLookup]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
chrome://global/content/autocomplete.xml#autocomplete.startLookup() ::
startLookup :: line 12"  data: no]

Comment 3

[Zach Lipton [:zach]]

This should probably be invalid because nothing says that you should do this.
It's kindof like filing a bug saying that when I delete dlls, shlbs, and .so
files, then the browser doesn't run... However, because it looks like Alecf has
some intention of fixing this at a later point in time, I'll confirm it. Alecf,
if I got you wrong here, let me know or close this out...

Thanks

Zach

Comment 4

[timeless]

this is one of those things that embedders would probably like, or people who 
want to run moz off a cdrom.

So is mork choking or what?

Comment 5

[Alec Flett]

reassign url bar bugs to new owner..

Comment 6

[Blake Ross]

reassigning url bar bugs to default owner.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch v1.0

Patch to fix.  Don't leave our listeners hanging because of our internal
problems!

Comment 8

[Boris Zbarsky [:bzbarsky]]

taking bug.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch v 1.1

Better patch

Comment 10

[Joe Hewitt (gone)]

Comment on attachment 68344 [details] [diff] [review]
Patch v 1.1

don't increment mFailureCount yourself, call this.searchFailed() which does
that and then some.

Comment 11

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch v 1.2

call this.searchFailed() (have to decrement this.mSessionReturns manually for
things to work, though).

Comment 12

[Joe Hewitt (gone)]

Comment on attachment 68445 [details] [diff] [review]
Patch v 1.2

sr=hewitt

Comment 13

[Boris Zbarsky [:bzbarsky]]

checked in