84828 - "advance to next unread" dialog has message as dialog title

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Jesse Ruderman]

When I hit 'N' in my inbox (which has no unread messages), I get a dialog asking
me "Advance to next unread message in bugmail?".  That's fine, but the title of
the dialog is also "Advance to next unread message in bugmail?".  The title of
the dialog should be something like "Mozilla MailNews".

Comment 1

[Andreas Premstaller]

I still see this with 2001100514 on Linux.

jglick: Is there any spec in place that says what the title should be? If not,
any suggestions?

Comment 2

[jglick]

Windows Guidelines recommend using the application name in this situation. 

Comment 3

[Andreas Premstaller]

jglick: So should it be "Mozilla" or "Mozilla MailNews"? I could find no other
dialog in Mozilla using this title. I found "Confirm Unsubscribe" or "Download
Headers", for example, and that would rather correspond to a title along the
lines of "Advance to Next Folder/Newsgroup" (using nicer wording).

I can produce a patch quickly if I am told what the title should be.

Comment 4

[jglick]

I believe it should actually be a variable used in the code so that the 
product name can be different (Netscape Mail vs Mozilla Mail, etc) as 
appropriate. Seth, can you elaborate?

Comment 5

[Andreas Premstaller]

The variable probably would go to messenger.properties next to
"advanceNextPrompt=Advance to next unread message in %S?".
I did not intend to hardcode the text into msgViewNavigation.js :-).

But what should the text be? "Brandname (Netscape/Mozilla/...) Mail", or
"Brandname Mail & Newsgroups" or ...?

Comment 6

[jglick]

Sorry i'm not much help here, but i'm not an engineer. I believe the "official" 
product names are defined in a global dtd file. I know for Netscape its 
"Netscape Mail & Newsgroups". For Mozilla version, I am not positive of the 
official name. "Mozilla Mail News" seems correct?

Comment 7

[Rich Gray (:rbgray)]

Attachment: duplicated dialogue text

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a8pre) Gecko/2007090101 SeaMonkey/2.0a1pre

Comment 8

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

Poor little falsely-challenged bug: if ConfirmEx should use BrandName for app-generated prompts that don't have a title, then that's a ConfirmEx bug (and one which I'm pretty sure is *also* filed by Jesse). We have no need for a title here, so the proper title is the "Confirm" that null gives until Confirm decides to use a different one. (Also? A title like "I can't think of a title for this" would have been better than repeating the prompt as the title.)

Comment 10

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/d73e661ae1dc