Closed Bug 848598 Opened 12 years ago Closed 12 years ago

[layers-refactoring] Double-free Shmem with async-video

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: nical, Assigned: nical)

References

Details

This bug is specific to the gfx branch and doesn't affect mozilla-central. The ownership model in the current state of the refactoring suffers the same problems as the one prior to the refactoring: it is not well and coherently defined. Our problem now is that TextureClient/Host fully own their shmems but they don't expect a shmem to be used on the main thread at the same time. With async video + the optimization to avoid one copy per frame, the data in the shmem is also referenced by a SharedYCbCrImage that thinks it owns the shmem. In parallel we have plans to change the memory model of texture host/clients into something where the client has more control, which would make solving this problem in a clean way easier. This is a big change thought and we don't want to risk postponing the landing in m-c so we will have to solve this double free problem in a more temporary and hacky way (which will not be more hacky than how we deal with it in mozilla-central currently anyway).
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.