848635 - Old queries based on tags are no longer listed in the page footer by default when upgrading from 4.0 or older to 4.2

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Frédéric Buclin]

I just realized that after the bmo upgrade, all my queries based on the old tagging system are no longer displayed in the page footer. This change has been silently made by mkanat without asking anyone for review, see bug 616185 comment 42. He mentions a discussion with me on IRC, but we never discussed removing these queries from the page footer. Here is the transcript from January 31, 2011:

(22:35:15) mkanat: LpSolit: Hey hey. Would you mind if I slightly fix up that Install::DB code for tags--the bit that you fixed?
(22:35:28) mkanat: LpSolit: I could either post a new patch and you could review it, or I could just do it as DB module owner, whatever you'd prefer.
(22:36:17) LpSolit: mkanat: what do you want to change?
(22:36:38) mkanat: LpSolit: Oh, wanted to put it in a transaction, remove the eval, use URI.pm.
(22:37:32) LpSolit: mkanat: adding the transaction is fine, but removing the eval {} won't work in case an installation is already partially updated
(22:37:44) mkanat: LpSolit: Those would have only existed for the past day or so, though.
(22:37:47) mkanat: LpSolit: Or even only for a few hours.
(22:37:54) LpSolit: mkanat: for a few hours only
(22:38:04) LpSolit: for 6 hours, I think
(22:38:19) mkanat: LpSolit: Okay. So I figure that they've probably all updated by now (at least, all our automated updaters have), so we can remove it so that we're not hiding any real errors that people experience when they update to 4.2 from 4.0 or earlier.
(22:38:48) LpSolit: mkanat: ok
(22:39:04) mkanat: LpSolit: Okay. I can post the patch for you, if you want.
(22:40:17) LpSolit: mkanat: just attach it to the bug, for the record
(22:40:21) mkanat: LpSolit: Okay.


There is no way to fix this problem for already upgraded installation as there is no way to know which saved searches were displayed in the page footer before the upgrade and which ones weren't. So all we can do is to fix this problem for installations which didn't upgrade to 4.2 or newer yet.

I first thought these saved searches were lost and I started recreating one of them, and suddenly saw that the message said "saved search updated" instead of "saved search created", which is how I realized that they were still somewhere in the DB. I had to go through my 40+ saved searches to re-enable the ones I previously had in my page footer. That's painful (and confusing for those who are not too familiar with Bugzilla).

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Comment 3

[:glob ✱]

Comment on attachment 737122 [details] [diff] [review]
patch, v1

r=glob

Comment 4

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Install/DB.pm
Committed revision 8617.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified Bugzilla/Install/DB.pm
Committed revision 8550.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified Bugzilla/Install/DB.pm
Committed revision 8210.