848707 - Neutralize UI selection colour

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Ian Barlow (:ibarlow)]

Attachment: visual sample

It's time to kill the bright orange gradient. It seemed like a good idea at the time, but in practice we may have overdone it a bit. We should still keep orange as an accent colour in our UI, but our general purpose select colour should be more neutral. 

Wherever we currently show the orange gradient selection, let's switch to 
Focus: #000000 with 10% opacity
Select/Touch: #000000 with 20% opacity. 

Areas we need to change
* Title bar elements (tab button, bookmark/refresh/menu icons)
* Tab tray title bar elements
* All menus
* Awesomebar lists
* Tab lists
* About:home thumbnails

Things we are *not* changing 
(these are the areas where we use orange as an accent)
* Orange URL bar outline
* Current page tab thumbnail outline
* Tab section indicator

Sample screenshot below, using doorhangers and context menus as an example.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 1: Highlight color

This changes the highlight color from a gradient to a solid 10% black.
On dark background, this will be 10% white (UX approved).

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 2: Focused color

This changes the focused color for the buttons (we are truly accessible now!)

Comment 3

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 1: Highlight color

An unwanted Makefile edit could have burnt few trees. Reverted back.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Attachment: Part 2: Focused color

Menu had a wrong "default" state color. Fixed.

Comment 5

[Sriram Ramasubramanian [:sriram]]

Note: We changed from a solid gradient to a translucent color. This depends on the color/image below to show the translucent color over it. From my testing, I didn't see any regression in this approach (as this is how Android does things). There is 1% chance that this might fail in Tabs and/or Menu button as we draw the curves ourselves. Please watch out for regressions and tag it to this bug.

Comment 6

[Aaron Train [:aaronmt]]

(In reply to Sriram Ramasubramanian [:sriram] from comment #5)
> There is 1% chance that this might fail

[citation needed] ;)

Comment 7

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b0a6d63bdec6
https://hg.mozilla.org/integration/mozilla-inbound/rev/67d0bd22fe14

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b0a6d63bdec6
https://hg.mozilla.org/mozilla-central/rev/67d0bd22fe14