852237 - Tabs button showing wrong color in pressed state

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

Android requires different backgrounds for different states. So, a pressed state background is all by itself, and not drawn over a default state. The Bug 848707 changed the pressed (and focused) state from a solid color to a translucent one. Though this might work on phones with h/w acceleration (due to pixel retention), this won't work on s/w model.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Ideally we should do,
<layer>
   <item android:drawable="light_color"/>
   <item android:drawable="20% black"/>
</layer>

But this is more computation for android. Instead, its better to get it the combined value by ourselves, as its a solid color.

Also, LayerDrawable should be used with personas too. However, that requires implementation mutate() for LWThemeDrawable. That doesn't seem a promising case of something under the finger. Hence the pressed and focused state will be solid colors for tabs and menu button with personas enabled.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch (part 2): Tablets

I missed the tablet part in previous patch. This has it. Can I fold them both and push it as a single changeset?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 726339 [details] [diff] [review]
Patch (part 2): Tablets

Yes, fold them together

Comment 4

[Sriram Ramasubramanian [:sriram]]

Folded and pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/fbef0319725b

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fbef0319725b