848901 - NFC causes crashes in GB phones

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

E/GeckoAppShell( 1586): >>> REPORTING UNCAUGHT EXCEPTION FROM THREAD 1 ("main")
E/GeckoAppShell( 1586): java.lang.NoClassDefFoundError: org.mozilla.gecko.BrowserApp$6
E/GeckoAppShell( 1586): 	at org.mozilla.gecko.BrowserApp.onCreate(BrowserApp.java:366)
E/GeckoAppShell( 1586): 	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1047)
E/GeckoAppShell( 1586): 	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1611)
E/GeckoAppShell( 1586): 	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:1663)
E/GeckoAppShell( 1586): 	at android.app.ActivityThread.access$1500(ActivityThread.java:117)
E/GeckoAppShell( 1586): 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:931)
E/GeckoAppShell( 1586): 	at android.os.Handler.dispatchMessage(Handler.java:99)
E/GeckoAppShell( 1586): 	at android.os.Looper.loop(Looper.java:130)
E/GeckoAppShell( 1586): 	at android.app.ActivityThread.main(ActivityThread.java:3683)
E/GeckoAppShell( 1586): 	at java.lang.reflect.Method.invokeNative(Native Method)
E/GeckoAppShell( 1586): 	at java.lang.reflect.Method.invoke(Method.java:507)
E/GeckoAppShell( 1586): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:839)
E/GeckoAppShell( 1586): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:597)
E/GeckoAppShell( 1586): 	at dalvik.system.NativeStart.main(Native Method)


And the corresponding piece of code is:
        if (Build.VERSION.SDK_INT >= 10) {
            NfcAdapter nfc = NfcAdapter.getDefaultAdapter(this);
            if (nfc != null) {
#line: 366      nfc.setNdefPushMessageCallback(new NfcAdapter.CreateNdefMessageCallback() {
                    @Override
                    public NdefMessage createNdefMessage(NfcEvent event) {
                        Tab tab = Tabs.getInstance().getSelectedTab();
                        if (tab == null || tab.isPrivate()) {
                            return null;
                        }
                        return new NdefMessage(NdefRecord.createUri(tab.getURL()));
                    }
                }, this);
            }
        }

Device running: 2.3.4

Comment 1

[Chris Peterson [:cpeterson]]

kats, NfcAdapter was added in API Level 9 (GB), but NfcAdapter.CreateNdefMessageCallback was added in API Level 14 (ICS):

https://developer.android.com/reference/android/nfc/NfcAdapter.CreateNdefMessageCallback.html

Comment 2

[Aaron Train [:aaronmt]]

noooooooooo fix it

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Only send via beam on API 14+

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 722552 [details] [diff] [review]
Only send via beam on API 14+

Looks good to me.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca3ccb294e2e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ca3ccb294e2e