Closed Bug 726335 Opened 8 years ago Closed 7 years ago

Use NDEF Push with NFC (Android Beam | API level 14) for transferring currently focused tab

Categories

(Firefox for Android :: General, enhancement)

ARM
Android
enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 24
Tracking Status
relnote-firefox --- 24+
blocking-fennec1.0 --- -
fennec - ---

People

(Reporter: aaronmt, Assigned: kats)

References

Details

(Keywords: feature, Whiteboard: [NFC])

Attachments

(3 files, 2 obsolete files)

tracking-fennec: --- → -
Not in the 1.0 scope.
blocking-fennec1.0: --- → -
Attached patch Receive URIs over NFC (obsolete) — Splinter Review
We probably want to defer this until we do a permission batch upgrade.
Attachment #720762 - Flags: review?(mark.finkle)
Attachment #720761 - Flags: review?(mark.finkle) → review+
Comment on attachment 720762 [details] [diff] [review]
Receive URIs over NFC


>+                <action android:name="android.nfc.action.NDEF_DISCOVERED"/>
>+                <category android:name="android.intent.category.DEFAULT" />
>+                <data android:scheme="http" />
>+                <data android:scheme="https" />

I suppose we don't need to worry about ftp or any other protocols

>-        } else if (Intent.ACTION_VIEW.equals(action)) {
>+        } else if (Intent.ACTION_VIEW.equals(action)
>+            || (Build.VERSION.SDK_INT >= Build.VERSION_CODES.GINGERBREAD_MR1
>+                && NfcAdapter.ACTION_NDEF_DISCOVERED.equals(action))) {

I cringe a little at the increased complexity of the "if" test. I'd almost be OK with treating it as a separate condition, even though the 2 lines of code would be duped.

As it stands right now, we'll need to comment this out when it hits Beta. There is a wiki page for managing that process:
https://wiki.mozilla.org/Release_Management/Merge_Documentation
Attachment #720762 - Flags: review?(mark.finkle) → review+
Actually, should most of this onNewIntent stuff be moved to BrowserApp.java instead? I assume we don't want to be doing this in web apps, right?
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #5)
> Actually, should most of this onNewIntent stuff be moved to BrowserApp.java
> instead? I assume we don't want to be doing this in web apps, right?

That's a better idea.
Ah, the intents don't get triggered on web apps anyway because the manifest entries are in the "App" activity, so it's not technically a problem, but I moved it over anyway for less confusion.
Attached patch Receive URIs over NFC (v2) (obsolete) — Splinter Review
Updated, carrying r+
Attachment #720762 - Attachment is obsolete: true
Attachment #721132 - Flags: review+
Updated to use "10" instead of the version code name to be consistent with the rest of BrowserApp.
Assignee: nobody → bugmail.mozilla
Attachment #721132 - Attachment is obsolete: true
Attachment #721152 - Flags: review+
Attachment #721154 - Flags: review?(mark.finkle) → review+
Depends on: 849281
There have been some very interesting flaws shown at security conferences regarding NFC, marking this for sec-review after the fact.
Flags: sec-review?
Flags: sec-review? → sec-review?(mgoodwin)
We won't note given bug 847898. We'll note once the feature is more ready for release.
Whiteboard: [NFC]
Target Milestone: Firefox 22 → Firefox 24
Adding the feature keyword to be included in the new Release Tracking page.
Keywords: feature
Flags: sec-review?(mgoodwin)
You need to log in before you can comment on or make changes to this bug.