Closed
Bug 848907
Opened 11 years ago
Closed 11 years ago
ship it should truncate long status lines rather than refuse them
Categories
(Release Engineering :: Release Automation: Other, defect)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
(Whiteboard: [shipit])
Attachments
(1 file)
|
10.52 KB,
patch
|
catlee
:
review+
bhearsum
:
checked-in+
|
Details | Diff | Splinter Review |
bug 848698 describes a problem where something in release runner failed, and then the status update to ship it failed because the status line was too long. This ended up with us having very little information to debug with. I think it would be better for ship it to truncate long status lines (and maybe return something saying as much in the response) rather than fail hard.
|
Assignee | |
Comment 1•11 years ago
|
||
Most of this patch is just me re-arranging code in forms.py -- I moved all of the helper stuff (custom fields, filters) above the actual Forms. The new stuff is: truncateFilter and its use, and the test code.
|
||
Updated•11 years ago
|
Attachment #724008 -
Flags: review?(catlee) → review+
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 724008 [details] [diff] [review] implement truncation filter Landed this. Dev will pick it up automatically, I'll push to prod once bug 848899 is ready.
Attachment #724008 -
Flags: checked-in+
|
|
Assignee | |
Comment 3•11 years ago
|
||
in production.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•