ship it should truncate long status lines rather than refuse them

RESOLVED FIXED

Status

Release Engineering
Release Automation: Other
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [shipit])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
bug 848698 describes a problem where something in release runner failed, and then the status update to ship it failed because the status line was too long. This ended up with us having very little information to debug with. I think it would be better for ship it to truncate long status lines (and maybe return something saying as much in the response) rather than fail hard.
(Assignee)

Comment 1

5 years ago
Created attachment 724008 [details] [diff] [review]
implement truncation filter

Most of this patch is just me re-arranging code in forms.py -- I moved all of the helper stuff (custom fields, filters) above the actual Forms. The new stuff is: truncateFilter and its use, and the test code.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Attachment #724008 - Flags: review?(catlee)

Updated

5 years ago
Attachment #724008 - Flags: review?(catlee) → review+
(Assignee)

Comment 2

5 years ago
Comment on attachment 724008 [details] [diff] [review]
implement truncation filter

Landed this. Dev will pick it up automatically, I'll push to prod once bug 848899 is ready.
Attachment #724008 - Flags: checked-in+
(Assignee)

Updated

5 years ago
Depends on: 850641
(Assignee)

Comment 3

5 years ago
in production.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.