849018 - User privacy setting page - Add addition id's to the html for automation to hook into

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Matt Brandt [:mbrandt]]

Attachment: qa - screenshot

I apologize for not making the needs for automation clearer. For each of the privacy setting drop downs use explicit id's for each of the elements.

Example:
For the photo settings drop down use something like id="privacy-photo-setting". Use unique ids for each of the drop down selectors on the edit profile page. 

<div class="control-group photo ">
  <label class="control-label" for="id_photo">Profile Photo</label>
    <div class="controls">
      <div class="privacy-controls">
        <select id="privacy-photo-setting" class="privacy-choice" name="">
           <option selected="selected">-- Select privacy mode --</option>
           <option value="public">Public</option>
           <option value="mozillians">Mozillians</option>
        </select>
     </div>

Comment 1

[Justin Crawford [:hoosteeno] [:jcrawford]]

These changes are deployed to https://mozillians-dev.allizom.org.

Comment 2

[Matt Brandt [:mbrandt]]

QA verified on dev. Thank you juliaelman. The new locators look great.

https://github.com/mozilla/mozillians/commit/1f9692a664daa04d030f987b48bd2a4127547f79

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/f5cbe40e49d9fea629f1413097903d8d5ce31df4
[bug 849018] Changing select dropdowns to have unique ids.

https://github.com/mozilla/mozillians/commit/1f9692a664daa04d030f987b48bd2a4127547f79
Merge pull request #427 from juliaelman/privacy-ui