849170 - [Buri][Dialer]When play landscape games, incoming call display in landscape, touch is not working

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[sync-1]

Firefox v1.0.1
 Mozilla build ID: 20130304070202.
 
 +++ This bug was initially created as a clone of Bug #416572 +++
 
 DEFECT DESCRIPTION:
 (1)try to play some landscape mode game, such as "cut the rope" , "Zombie lines"
 (2)Make an incoming call
 (3)the incoming call screen will appear in landscape, here it is still ok, you can refuse, also you can answer the call
 (4)try to answer the call, you will find the screen display is not very well, some areas are overlapped, and the most defect is that the touch is not working for "MUTE" "KEYPAD" "SPEAKER" icons. --NOK1,  Only the "Hangup" is working 
 (5)And in this case, 80% possibility, rotation is not working, can not change to Portrait mode when totate the screen --- NOK2
 
 REPRODUCING PROCEDURES:
 
 EXPECTED BEHAVIOUR:
 For NOK1 and NOK2, the most simple solution is "always display the call screen in Portrait mode"  to avoid such error occur.
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 Serious
 REPRODUCING RATE:
 100%
 For FT PR, Please list reference mobile's behavior:
 
 ++++++++++ end of initial bug #416572 description ++++++++++
 
 
 
 CONTACT INFO (Name,Phone number):
 
 DEFECT DESCRIPTION:
 
 REPRODUCING PROCEDURES:
 
 EXPECTED BEHAVIOUR:
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 
 REPRODUCING RATE:
 
 For FT PR, Please list reference mobile's behavior:

Comment 1

[Amelie Kong]

Attachment: The landscape call screen

You can see something is displayed overlapping, and also the touch icons are not working.

Comment 2

[Andrew Overholt [:overholt]]

This might be a dupe of bug 843390.

Alive, who can do this work?

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Taken, and I found another issue here:
When you are in a fullscreen app, the call screen's top would be cut off.
I am not sure if I shall fix it in this bug. Should be a simple fix though.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/8591

WIP Patch:
Set orientation of attention screen to portrait-primary.

I don't fix the fullscreen + attention screen in this issue.

Trying to see if I could write a unit test for this.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 723834 [details]
https://github.com/mozilla-b2g/gaia/pull/8591

See previous comment (Let's forget the Unit test...)

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 723834 [details]
https://github.com/mozilla-b2g/gaia/pull/8591

Please try to delegate this kind of easy fix to other people next time so we could be more productive as a team.

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

https://github.com/mozilla-b2g/gaia/commit/debb2766b8c658decc51a267eb89ac309c2a828f

Merged, need uplift.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit debb2766b8c658decc51a267eb89ac309c2a828f as:
v1-train: dacdff25a5fb3970d7d6051ffd148a398103f90c
v1.0.1: 4c307167d8d74486201efcfd171e613b670a987d

Comment 9

[Amelie Kong]

Sorry, wrong operation here.

Comment 10

[Cody Roesch [:croesch]]

Unagi Build: 20130322070202
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/5aacf880400b
Gaia   5a31a56b96a8fc559232d35dabf20411b9c2ca1d
Kernel: Dec 5th

In the build above, I have tested a few games in Landscape view and made a call to the test device. In each instance, the phone call was seen in portrait view and answered or cancelled correctly.