849342 - Defect - Remember passwords preference does not take effect some times

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect, P1)

Description

[juan becerra [:juanb]]

Tested on 2013-03-08 on nightly built from http://hg.mozilla.org/mozilla-central/rev/cb432984d5ce

While verifying bug 838734 I often saw that toggling the remember passwords preference in the Options didn't take effect immediately most of the time. The password info bar did not come up after toggling it from off to on.

Steps:
1. Go to gmail.com
2. Enter your credentials but opt not to save password when prompted.
3. Logout
4. Open the Settings charm and select the Options. Toggle the "remember passwords" preference from On to Off.
5. Login and logout again.
6. Toggle the preference back to on.
7. Login with your credentials.

Expected: Password info bar comes up giving you the option to save your password.

Actual: Info bar does not show up. This is different from the desktop version where this takes effect immediately.

Reproducible: More than 50% of the time.

You can also try:

1. Login in to gmail.com and save the password the first time you login
2. Flipping the preference to Off
3. Then attempting to login with another username and password (should not prompt you to save).
4. Flip the preference back to On 
5. Attempt to login with second user account.

After that 5th step you should see the password info bar, but I don't see it consistently.

Comment 1

[Marco Mucci [:MarcoM]]

Hi Juan, which original story can I link this defect to?

Comment 2

[Asa Dotzler [:asa]]

I think this is probably a defect in bug 831977 Story - Login Form Filling

Comment 3

[juan becerra [:juanb]]

I don't know if this is a defect in bug 838734 (use a beautifully styled remember login...) or bug 831958 (access the options flyout) which has the work associated with the preferences switches.

Whichever is responsible for making the password info bar come up or not.

Comment 4

[Marco Mucci [:MarcoM]]

Hey Asa, please see Juan's comment #3.

Comment 5

[Asa Dotzler [:asa]]

I think the best is to have this defect block bug 831977 - Story - Login Form Filling.

Comment 6

[Brian R. Bondy [:bbondy]]

After reading the description more closely, this is probably just adding a pref observer, lowering from 3 to 2.

Comment 7

[Brian R. Bondy [:bbondy]]

And again to 1, easier than I thought.

Comment 8

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

observe() code was probably originally copied from LoginManagerChild.js which had a _pwmgr, but the pref observer is on the this object for loginmanager.js as is the _remember and _debug properties.

Comment 9

[Brian R. Bondy [:bbondy]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2930b46ad0b5

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/2930b46ad0b5

Comment 11

[juan becerra [:juanb]]

Tested on 2013-03-20 using Nightly built from http://hg.mozilla.org/mozilla-central/rev/8156df33b757
- Tested with steps in comment #0. I see the remember passwords info bar come up or not as expected, when toggling the preference.

Comment 12

[Kamil Jozwiak [:kjozwiak]]

Went through the following "Defect" for iteration #7 testing without any issues. Used the following build:

http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-05-28-03-09-42-mozilla-central/

- Went through both of the test cases in Comment 0 several times on several different websites without any issues.
- Ensured that the "Remember Password Info Bar" appeared as expected
- Ensured that the "Remember Password Info Bar" didn't appear when expected
- Ensured that passwords that where previously saved where still saved after toggling "Remember Password"

Comment 13

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment12 and got expected result.