849608 - Change - Auto close about, settings, and sync flyout panels on snap view

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Browser, defect, P1)

Description

[Kamil Jozwiak [:kjozwiak]]

You can't open these flyouts from snap view because the charm options only apply to the bigger of the 2 snapped applications. But if you happen to open one of these flyouts, and then you switch to snapped view, the user may be confused. There is no back button because it is cut off.

Steps to reproduce the issue:

1. Open Metro Firefox
2. Open the charms bar (Windows key + C)
3. Click on the "Settings" charm
4. Click on "Options"
5. Enter into snapped mode for Metro Firefox so it is the smaller app

Actual Results:
Part of the pane is displayed.

Expected Results:
Either the pane is automatically dismissed or it is small enough to be fully visible.

Comment 1

[Asa Dotzler [:asa]]

We should totally close any of our open flyouts when we go into snapped mode.  I don't think this is a commonly encountered edge case and the work around (just swipe in from top or bottom of screen to dismiss or move back to full screen or fill view.) Because of that, I don't think we need this in v1.

Comment 2

[Brian R. Bondy [:bbondy]]

p=1 for approach
> We should totally close any of our open flyouts when we go into snapped mode

Comment 3

[Marco Mucci [:MarcoM]]

Would this be a new story or change to an existing story?

Comment 4

[Brian R. Bondy [:bbondy]]

Would be a defect of both bug 831955 and bug 831958 if you want to do it.

Comment 5

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

Comment 6

[Brian R. Bondy [:bbondy]]

Marking needs checking in case someone can land before I can. m-i tree is currently closed.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a6e4fc1312bd

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a6e4fc1312bd

Comment 9

[Marco Mucci [:MarcoM]]

Temporarily reopening this to include in Iteration #4.  It will be resolved immediately after the start of the iteration.

Comment 10

[juan becerra [:juanb]]

Tested on 2013-03-15 using Nightly built from http://hg.mozilla.org/mozilla-central/rev/0f7261e288f2
- Tested using steps from comment #0 and now the all the flyouts you can access within the Settings/Options are auto dismissed when you go into snapped view (left or right).

Comment 11

[Samvedana (:Samvedana)]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and got expected result. The pane was automatically dismissed.