Change - Auto close about, settings, and sync flyout panels on snap view

VERIFIED FIXED

Status

Firefox for Metro
Browser
P1
normal
VERIFIED FIXED
5 years ago
3 years ago

People

(Reporter: kjozwiak, Assigned: bbondy)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: feature=change c=Settings_pane_options_and_about u=metro_firefox_user p=1 status=verified)

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
You can't open these flyouts from snap view because the charm options only apply to the bigger of the 2 snapped applications. But if you happen to open one of these flyouts, and then you switch to snapped view, the user may be confused. There is no back button because it is cut off.

Steps to reproduce the issue:

1. Open Metro Firefox
2. Open the charms bar (Windows key + C)
3. Click on the "Settings" charm
4. Click on "Options"
5. Enter into snapped mode for Metro Firefox so it is the smaller app

Actual Results:
Part of the pane is displayed.

Expected Results:
Either the pane is automatically dismissed or it is small enough to be fully visible.
(Assignee)

Updated

5 years ago
Whiteboard: p=2

Updated

5 years ago
Flags: needinfo?(jbecerra)
QA Contact: jbecerra

Comment 1

5 years ago
We should totally close any of our open flyouts when we go into snapped mode.  I don't think this is a commonly encountered edge case and the work around (just swipe in from top or bottom of screen to dismiss or move back to full screen or fill view.) Because of that, I don't think we need this in v1.
No longer blocks: 841214
(Assignee)

Comment 2

5 years ago
p=1 for approach
> We should totally close any of our open flyouts when we go into snapped mode
Whiteboard: p=2 → p=1
Would this be a new story or change to an existing story?
Flags: needinfo?(jbecerra)
(Assignee)

Comment 4

5 years ago
Would be a defect of both bug 831955 and bug 831958 if you want to do it.

Updated

5 years ago
Blocks: 831955, 831958, 841214
Priority: -- → P5
Summary: Consider making about, settings, and sync flyout panels max width to be that of snap view → Change - Consider making about, settings, and sync flyout panels max width to be that of snap view
Whiteboard: p=1 → feature=change c=Settings_pane_options_and_about u=metro_firefox_user p=1
(Assignee)

Updated

5 years ago
Summary: Change - Consider making about, settings, and sync flyout panels max width to be that of snap view → Change - Auto close about, settings, and sync flyout panels on snap view
(Assignee)

Comment 5

5 years ago
Created attachment 724237 [details] [diff] [review]
Patch v1.
Assignee: nobody → netzen
Attachment #724237 - Flags: review?(mbrubeck)
(Assignee)

Updated

5 years ago
Blocks: 842108
No longer blocks: 841214
Attachment #724237 - Flags: review?(mbrubeck) → review+
(Assignee)

Comment 6

5 years ago
Marking needs checking in case someone can land before I can. m-i tree is currently closed.
Keywords: checkin-needed

Updated

5 years ago
Priority: P5 → P1
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6e4fc1312bd
Keywords: checkin-needed

Comment 8

5 years ago
https://hg.mozilla.org/mozilla-central/rev/a6e4fc1312bd
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Temporarily reopening this to include in Iteration #4.  It will be resolved immediately after the start of the iteration.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

5 years ago
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Flags: needinfo?(jbecerra)
Tested on 2013-03-15 using Nightly built from http://hg.mozilla.org/mozilla-central/rev/0f7261e288f2
- Tested using steps from comment #0 and now the all the flyouts you can access within the Settings/Options are auto dismissed when you go into snapped view (left or right).
Status: RESOLVED → VERIFIED
Flags: needinfo?(jbecerra)
Whiteboard: feature=change c=Settings_pane_options_and_about u=metro_firefox_user p=1 → feature=change c=Settings_pane_options_and_about u=metro_firefox_user p=1 status=verified
User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130825030201
Built from http://hg.mozilla.org/mozilla-central/rev/01576441bdc6

WFM
Tested on windows 8 using latest nightly for iteration-12. Followed steps provided in comment0 and got expected result. The pane was automatically dismissed.
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.