Open Bug 849657 Opened 7 years ago Updated 4 years ago

change eCSSProperty_* constants to use DOM names

Categories

(Core :: CSS Parsing and Computation, defect)

defect
Not set

Tracking

()

People

(Reporter: dbaron, Assigned: dbaron)

References

(Blocks 1 open bug)

Details

(Whiteboard: [leave open])

Attachments

(2 files)

So I was thinking of changing the names of our internal eCSSProperty_* constants to use the property names that are used for DOM methods.  In other words, I'd change:
  eCSSProperty_font_size -> eCSSProperty_FontSize

This would allow removing a field from nsCSSPropList.h .  It would also match what I did for property alias names in bug 849656.
What do you all think of this idea?
Seems reasonable to me.
Comment on attachment 728853 [details] [diff] [review]
patch 1: Expose CSS_PROP_PUBLIC_OR_PRIVATE macro to users of nsCSSPropList.h rather than CSS_PROP_DOMPROP_PREFIXED, so that we can avoid 'CssFloat' spreading even further.

r=me
Attachment #728853 - Flags: review?(bzbarsky) → review+
Comment on attachment 728854 [details] [diff] [review]
patch 2: Change internal uses of 'CssFloat' to 'Float'.

r=me
Attachment #728854 - Flags: review?(bzbarsky) → review+
OK, those initial patches landed:
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/eb8d19e9c838
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d20bf3793eb2

I think I need to write the primary substitution patch using sed.
Whiteboard: [leave open]
(We should perhaps make this an enum class at the same time, actually.)
You need to log in before you can comment on or make changes to this bug.