849657 - change eCSSProperty_* constants to use DOM names

Status: NEW

(Core :: CSS Parsing and Computation, defect)

Description

[David Baron :dbaron:]

So I was thinking of changing the names of our internal eCSSProperty_* constants to use the property names that are used for DOM methods.  In other words, I'd change:
  eCSSProperty_font_size -> eCSSProperty_FontSize

This would allow removing a field from nsCSSPropList.h .  It would also match what I did for property alias names in bug 849656.

Comment 1

[David Baron :dbaron:]

What do you all think of this idea?

Comment 2

[Zack Weinberg (:zwol)]

Seems reasonable to me.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Sounds fine.

Comment 4

[Cameron McCormack (:heycam)]

Seems OK.

Comment 5

[David Baron :dbaron:]

Attachment: patch 1: Expose CSS_PROP_PUBLIC_OR_PRIVATE macro to users of nsCSSPropList.h rather than CSS_PROP_DOMPROP_PREFIXED, so that we can avoid 'CssFloat' spreading even further.

Comment 6

[David Baron :dbaron:]

Attachment: patch 2: Change internal uses of 'CssFloat' to 'Float'.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 728853 [details] [diff] [review]
patch 1: Expose CSS_PROP_PUBLIC_OR_PRIVATE macro to users of nsCSSPropList.h rather than CSS_PROP_DOMPROP_PREFIXED, so that we can avoid 'CssFloat' spreading even further.

r=me

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 728854 [details] [diff] [review]
patch 2: Change internal uses of 'CssFloat' to 'Float'.

r=me

Comment 9

[David Baron :dbaron:]

OK, those initial patches landed:
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/eb8d19e9c838
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/d20bf3793eb2

I think I need to write the primary substitution patch using sed.

Comment 10

[David Baron :dbaron:]

Plus bustage fix:  https://hg.mozilla.org/integration/mozilla-inbound/rev/3178d9b2406d

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/eb8d19e9c838
https://hg.mozilla.org/mozilla-central/rev/d20bf3793eb2
https://hg.mozilla.org/mozilla-central/rev/3178d9b2406d

Comment 12

[David Baron :dbaron:]

(We should perhaps make this an enum class at the same time, actually.)