849751 - Add UI for Corporate Lock and ServiceProvider Lock

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Joe Cheng [:jcheng] (please needinfo)]

this is to follow up on bug 808808 to have work done on Gaia

Comment 1

[Anshul]

This should be leo+ as it blocks a blocker.

Comment 2

[Anshul]

Is someone looking at this bug and do we have an estimate on when this support be available?

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

We could reuse the NCK lock UI in the System for this.

I am looking for an assignee in Taipei right now.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/8698

Added UI in system app and FTU for handling nck/cck/spck locks. Tim, Fernando, please help review the change. Thanks.

Comment 5

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 726030 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/8698

Looks good except lint error :-/

Fernando might need to take a second look though.

Comment 6

[Fernando Campo (:fcampo)]

Comment on attachment 726030 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/8698

Code looks good to me too, though I couldn't test it as I don't have any locked simcard around.
Also, I don't have access to the original bug 808808, so I'm just inferring the expected behaviour in this one, but looks simple enough :)

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Tim, Fernando, thank you for reviewing.

master: https://github.com/mozilla-b2g/gaia/commit/eac11c5bb41b6fbf0348470ba720a6cd7b1783cb

Comment 8

[Dylan Oliver [:doliver]]

triage: leo+ due to blocking a blocker bug 808808

Comment 9

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted commit eac11c5bb41b6fbf0348470ba720a6cd7b1783cb as:
v1-train: 34ea31b70fdb49467255a6ec3dddc4c38c41572d