849876 - [B2G][FM radio] Blank white screen is shown when launching FM radio

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Description

[Chris Kreinbring [:CKreinbring]]

Attachment: Log of launching FM Radio

Repro steps:

1. From the homescreen, select FM Radio.
2. Observe the state of FM Radio when it loads.
3. Exit the app.
4. Plug in the headphones and launch FM Radio again.
5. Observe the state of FM Radio when it loads.

Expected:
FM Radio launches both times without errors.

Actual:
A blank white screen is shown when FM Radio launches regardless of whether or not the headphones are plugged in.

Note: If the user had the radio set to a station before updating to today's build, that station will still play if the headphones are plugged in.

Unagi build 20130311070203
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/aec2f0738fab
Gaia: 067c040f3f16d5660ab1e117abf0834f1509d6f3
Kernel Date: Dec 5

Comment 1

[Chris Kreinbring [:CKreinbring]]

Still repros in Unagi build 20130311095652
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a56593f84577
Gaia: 69cfb9f7d00e5ee7886e40645240686091b6b57e
Kernel Date: Dec 5

Comment 2

[Marcia Knous [:marcia]]

03-11 14:29:10.914: W/AudioPolicyManagerBase(118): getDeviceCategory() invalid device combination: 00000000 shows up in logcat.

This is a recent regression since it was working during the smoketest on Friday.

Comment 3

[Andrew Overholt [:overholt]]

Andrea, can you please take a look here?

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

White flashing before apps have always occurred.  There's many white flashing bugs to show this.  bug 829411 bug 835292 	


Marcia, did you report getDeviceCategory as a different bug?  That's a different bug.

Comment 5

[Marcia Knous [:marcia]]

This is not an instance of flashing - the FM radio UI does not show at all - all that can be seen is a blank white screen when you launch the app.

I pasted what I saw in logcat because of the AudioPolicyManagerBase - I thought that related to FM Radio.

(In reply to Naoki Hirata :nhirata from comment #4)
> White flashing before apps have always occurred.  There's many white
> flashing bugs to show this.  bug 829411 bug 835292 	
> 
> 
> Marcia, did you report getDeviceCategory as a different bug?  That's a
> different bug.

Comment 6

[Julien Wajsberg [:julienw]]

This is due to an infortunate change in Bug 841353.

I have a fix ready.

Comment 7

[Julien Wajsberg [:julienw]]

Attachment: patch v1

Revert an unfortunate change from bug 841353
---
 apps/fm/index.html |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

see also PR https://github.com/mozilla-b2g/gaia/pull/8603

Comment 8

[Julien Wajsberg [:julienw]]

Asking for tef+ as it is a regression from Bug 841353 and I landed it already on v1.0.1 as part of the uplift.

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Interesting.  I had used it one with headset and I just only saw the white flash on first launch.  I must have been using an older build.  I see the white only screen now.  Thanks for the patch, Julien

Comment 10

[Julien Wajsberg [:julienw]]

There may be other bugs too ;-)

Comment 11

[Pin Zhang [:pzhang] (inactive)]

Comment on attachment 724153 [details] [diff] [review]
patch v1

Review of attachment 724153 [details] [diff] [review]:
-----------------------------------------------------------------

Verified on Unagi.

Comment 12

[Julien Wajsberg [:julienw]]

Attachment: patch v2

Fix the hidden change from bug 841353
---
 apps/fm/js/fm.js |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

See also PR https://github.com/mozilla-b2g/gaia/pull/8603

During the night I thought that the initial change was made to reduce flickering while lazy loading the CSS file. And with this more proper fix the loading flickering is indeed reduced a lot. So I think it's worth asking for another review for this.

Thanks

Comment 13

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 724310 [details] [diff] [review]
patch v2

r=me in case you need another one's review, it looks a simple and valid fix.

Comment 14

[Julien Wajsberg [:julienw]]

master: https://github.com/mozilla-b2g/gaia/commit/fd4ea06450fd6d83f4177c338b55c3e1de02e6d5

Note that I see other problems that we'll need to fix too (can't chose the frequency, phone is freezing...)

Comment 15

[Julien Wajsberg [:julienw]]

ok, seems like my first fix keeps the frequency after all.

I'll revert the commit and push the first one (already r+) and file a new bug for the flickering issue.

Sorry

Comment 16

[Julien Wajsberg [:julienw]]

master: revert hash is eec9fc0f6f379357bde98e1f8ffeb8e05474592b
master: new commit hash is 51c751d845a7640c5421db357a5fcc543cb8be30

marking v1.0.1 as fixed because the fix is already there.

Comment 17

[Julien Wajsberg [:julienw]]

hash for the fix in v1.0.1 is c342bb232e46bb88714ead96e2401f5815f3ea67 (landed with uplift to Bug 841353)

Comment 18

[Julien Wajsberg [:julienw]]

v1-train: cc7c0f627c25bc4d62afa781b482c3bdf963843a

Comment 19

[J Zimbrick]

Issue no longer appears to occur in the following Unagi build:

Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8e9dd87b4f3b
Gaia: 69dbcd84085f10bec0c0189b926ffb535b14dcfe
Build: 20130314114915

Opening the FM Radio app no longer opens to a blank white screens, now appears to function as intended with all features usable.

Verifying as fixed.

Comment 20

[Askeing Yen[:askeing][:fyen]]

Unagi
Gaia:     69dbcd84085f10bec0c0189b926ffb535b14dcfe
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18/rev/8e9dd87b4f3b
BuildID   20130314114915
Version   18.0

Verified, too.