850077 - tooltips do not work in the sidebar

Status: VERIFIED FIXED

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

If you have a button element with a title attribute, hovering over the button produces a tooltip in normal browser tabs.  The tooltip will not appear in the sidebar.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: fix tooltips in social frames

I'd like to also see if it is possible to uplift this to 21.

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 724180 [details] [diff] [review]
fix tooltips in social frames

[Approval Request Comment]
User impact if declined: tooltips in social content do not work (e.g. alt/title attributes in html)
Testing completed (on m-c, etc.): manual testing
Risk to taking this patch (and alternatives if risky): low to none, only affects social content, only adding an attribute to our iframes.  uses same code for tooltips that browser tabs use
String or UUID changes made by this patch: none

Comment 3

[:Gavin Sharp [email: [e-mail]]]

This doesn't seem serious enough to merit tracking, though I did approve the patch.

Comment 4

[Shane Caraveo (:mixedpuppy)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cb810d07bc93

https://hg.mozilla.org/releases/mozilla-aurora/rev/b01807d9550e

Comment 5

[Shane Caraveo (:mixedpuppy)]

(In reply to Shane Caraveo (:mixedpuppy) from comment #4)
> https://hg.mozilla.org/integration/mozilla-inbound/rev/cb810d07bc93
> 
> https://hg.mozilla.org/releases/mozilla-aurora/rev/b01807d9550e

sigh, wrong link for inbound in previous comment.

https://hg.mozilla.org/integration/mozilla-inbound/rev/aacd96764391

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aacd96764391

Comment 7

[Simona Badau, Desktop QA]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101 Firefox/21.0
Build ID: 20130401192816

I checked on the Social Api sidebar but I didn't see any tooltips. On what elements should I see a tooltip?

Comment 8

[u279076]

(In reply to Simona B [QA] from comment #7)
> Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:21.0) Gecko/20100101
> Firefox/21.0
> Build ID: 20130401192816
> 
> I checked on the Social Api sidebar but I didn't see any tooltips. On what
> elements should I see a tooltip?

It's up to the provider to enable tooltips in their content, but I think date/time of a post on a flyout should show a tooltip with Facebook.

Comment 9

[Shane Caraveo (:mixedpuppy)]

I'm in process of updating the demo provider on github to make some of these items easier to test.  my version has a tooltip on a button specifically for this bug.

Comment 10

[Shane Caraveo (:mixedpuppy)]

With aurora, you can activate the provider at 

http://mixedpuppy.github.com/socialapi-demo/

The "Chat Panel" button in the sidebar has a tooltip.

Comment 11

[Simona Badau, Desktop QA]

Verified as fixed on Firefox 21 beta 1 and Aurora 22.0a2.

Verified on Windows 7, Ubuntu 12.04, and Mac OS 10.7.5:
Mozilla/5.0 (Windows NT 6.1; rv:21.0) Gecko/20100101 Firefox/21.0 (20130401192816)
Mozilla/5.0 (Windows NT 6.1; rv:22.0) Gecko/20130403 Firefox/22.0 (20130403004013)

Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20100101 Firefox/21.0(20130401192816)
Mozilla/5.0 (X11; Linux i686; rv:22.0) Gecko/20130403 Firefox/22.0(20130403004013)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:21.0) Gecko/20100101 Firefox/21.0 
(20130401192816)
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:22.0) Gecko/20130403 Firefox/22.0
(20130403004013)

Thanks Shane for the demo.

Comment 12

[u279076]

Marking verified fixed based on Simona's testing. Thank you Simona.