850112 - Enable A-GPS prefs

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

Enable default A-GPS settings for all builds. Like gaia/build/payment-prefs.js, it should be customized as needed.

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Pull request

Comment 2

[[:fabrice] Fabrice Desré]

master: https://github.com/mozilla-b2g/gaia/commit/d0b8c383570e109574563472840f78030f5d1b9d

Comment 3

[Michael Vines [:m1] [:evilmachines]]

(tef- as this is not required for v1.0.1.  A-GPS configuration is not configured in this mannor in the commercial v1.0.1 builds)

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #3)
> (tef- as this is not required for v1.0.1.  A-GPS configuration is not
> configured in this mannor in the commercial v1.0.1 builds)

Can you provide more details on how it's going to be configured for tef?

Andreas requested this to be landed to all branches today. LEO+ first

Comment 5

[Michael Vines [:m1] [:evilmachines]]

We use /system/etc/gps.conf for this, and other location, configuration items

Comment 6

[Andreas Gal :gal]

Michael, can we get your changes landed in our tree then? Our dogfooders can't test this right now, and we are running out of time to get this some test coverage.

Comment 7

[Andreas Gal :gal]

Touched base with our partners. The patch can land on 1.0.1/TEF, they don't mind. They don't really need it since they overwrite the config with their own stuff, but we should land this right now so we can test on our end. So please uplift. Marking TEF+ for convenience, this is not really a blocker.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1-train: https://github.com/mozilla-b2g/gaia/commit/6b3282eaf2b7bf52d55112d8690d62085bdc93aa
v1.0.1: https://github.com/mozilla-b2g/gaia/commit/1438da6ca0e020a8df686e2100a668370dfe6fb6

Comment 9

[Daniel Coloma:dcoloma]

Marking the bug as resolved based in the branch status

Comment 11

[Jeni]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 12

[Kan-Ru Chen [:kanru] (UTC+9)]

This can't be verified from the UI..

Comment 13

[Tony Chung [:tchung]]

(In reply to Kan-Ru Chen [:kanru] from comment #12)
> This can't be verified from the UI..

is there a config we can set to point to a a-gps station?   i think we can verify from the UI, at least by comparing location speed, something like one phone on NOkia maps using AGPS, and the other phone using geolcation.

keep in mind we're in the US.   Thanks.

Comment 14

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to Tony Chung [:tchung] from comment #13)
> (In reply to Kan-Ru Chen [:kanru] from comment #12)
> > This can't be verified from the UI..
> 
> is there a config we can set to point to a a-gps station?   i think we can
> verify from the UI, at least by comparing location speed, something like one
> phone on NOkia maps using AGPS, and the other phone using geolcation.
> 
> keep in mind we're in the US.   Thanks.

You could change the config in B2G/gaia/build/gps-prefs.js

Yes, location speed should be improved with a-gps on, but sometimes it doesn't due to poor signal condition. I'm afraid there might be false alarms using this method.