Closed Bug 850126 Opened 7 years ago Closed 7 years ago

token id defined twice on logged out pages

Categories

(Bugzilla :: User Interface, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
Bugzilla 4.2

People

(Reporter: glob, Assigned: reed)

References

Details

Attachments

(1 file)

the hidden field named "token", with id "token", is defined twice for logged out users - once in forgot_form_top and again in forgot_form_bottom.
Attached patch patch - v1Splinter Review
untested
Assignee: ui → reed
Status: NEW → ASSIGNED
Attachment #723803 - Flags: review?(glob)
Comment on attachment 723803 [details] [diff] [review]
patch - v1

if the id attribute is used, this patch would break things.
if the id attribute isn't used, it would be simpler to just remove it from the field rather than renaming it.
Attachment #723803 - Flags: review?(glob) → review-
Comment on attachment 723803 [details] [diff] [review]
patch - v1

No, it should stay, but renamed. Without an ID, you would have no chance to correctly identify this field as you would have several fields with the same name (automated QA tests!). r=LpSolit
Attachment #723803 - Flags: review+
Waiting for glob to withdraw his r-. :)
Depends on: 706271
Flags: approval?
Flags: approval4.4?
Flags: approval4.2?
Target Milestone: --- → Bugzilla 4.2
Comment on attachment 723803 [details] [diff] [review]
patch - v1

(In reply to Frédéric Buclin from comment #3)
> No, it should stay, but renamed. Without an ID, you would have no chance to
> correctly identify this field as you would have several fields with the same
> name (automated QA tests!). r=LpSolit

this isn't true, you can reference the tokens via the form:
document.getElementById('forgot_form_top')['token']
document.getElementById('forgot_form_bottom')['token']

but if it makes your life easier, and doesn't break existing functionality, i'm happy to withdraw my r-
Attachment #723803 - Flags: review-
(In reply to Byron Jones ‹:glob› from comment #5)
> this isn't true, you can reference the tokens via the form:
> document.getElementById('forgot_form_top')['token']

FYI, our Selenium scripts are written in Perl, not JS. ;) And your code is heavily dependent on the DOM of the page, which makes it rather fragile. That's why I opened bug 317694 and bug 449067 some years ago, to make our life easier when writing automated tests.
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval4.2?
Flags: approval4.2+
Flags: approval+
Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/account/auth/login-small.html.tmpl
Committed revision 8589.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.4/
modified template/en/default/account/auth/login-small.html.tmpl
Committed revision 8529.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.2/
modified template/en/default/account/auth/login-small.html.tmpl
Committed revision 8196.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.