850126 - token id defined twice on logged out pages

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[:glob ✱]

the hidden field named "token", with id "token", is defined twice for logged out users - once in forgot_form_top and again in forgot_form_bottom.

Comment 1

[Reed Loden [:reed]]

Attachment: patch - v1

untested

Comment 2

[:glob ✱]

Comment on attachment 723803 [details] [diff] [review]
patch - v1

if the id attribute is used, this patch would break things.
if the id attribute isn't used, it would be simpler to just remove it from the field rather than renaming it.

Comment 3

[Frédéric Buclin]

Comment on attachment 723803 [details] [diff] [review]
patch - v1

No, it should stay, but renamed. Without an ID, you would have no chance to correctly identify this field as you would have several fields with the same name (automated QA tests!). r=LpSolit

Comment 4

[Frédéric Buclin]

Waiting for glob to withdraw his r-. :)

Comment 5

[:glob ✱]

Comment on attachment 723803 [details] [diff] [review]
patch - v1

(In reply to Frédéric Buclin from comment #3)
> No, it should stay, but renamed. Without an ID, you would have no chance to
> correctly identify this field as you would have several fields with the same
> name (automated QA tests!). r=LpSolit

this isn't true, you can reference the tokens via the form:
document.getElementById('forgot_form_top')['token']
document.getElementById('forgot_form_bottom')['token']

but if it makes your life easier, and doesn't break existing functionality, i'm happy to withdraw my r-

Comment 6

[Frédéric Buclin]

(In reply to Byron Jones ‹:glob› from comment #5)
> this isn't true, you can reference the tokens via the form:
> document.getElementById('forgot_form_top')['token']

FYI, our Selenium scripts are written in Perl, not JS. ;) And your code is heavily dependent on the DOM of the page, which makes it rather fragile. That's why I opened bug 317694 and bug 449067 some years ago, to make our life easier when writing automated tests.

Comment 7

[Reed Loden [:reed]]

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/trunk/
modified template/en/default/account/auth/login-small.html.tmpl
Committed revision 8589.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.4/
modified template/en/default/account/auth/login-small.html.tmpl
Committed revision 8529.

Committing to: bzr+ssh://bzr.mozilla.org/bugzilla/4.2/
modified template/en/default/account/auth/login-small.html.tmpl
Committed revision 8196.