Closed Bug 850214 Opened 7 years ago Closed 7 years ago

Update services/common/preferences.js usage of contentPrefs to nsIContentPrefService2

Categories

(Cloud Services :: Firefox: Common, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla22

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

Attachments

(1 file)

Use the new API added in bug 699859
Hey Richard, the preferences.js API supports a site-specific mode that uses the per-domain contentPrefs service instead of the regular prefs. However, the API from preferences.js is sync, and contentPrefs is moving to an async API (bug 831208).

*But*, site-specific mode is currently unused! So this patch just removes support for it from preferences.js.  Even if it was used, instead of changing preferences.js to async and totally re-engineering all of its many consumers, it'd be better to split site-specific mode into its own API and change only those consumers. But that won't even be necessary since it's not used right now.
Assignee: nobody → felipc
Status: NEW → ASSIGNED
Attachment #727827 - Flags: review?(rnewman)
Comment on attachment 727827 [details] [diff] [review]
Remove site-specific support from preferences.js

Review of attachment 727827 [details] [diff] [review]:
-----------------------------------------------------------------

Yay less code!
Attachment #727827 - Flags: review?(rnewman) → review+
Target Milestone: --- → mozilla22
https://hg.mozilla.org/mozilla-central/rev/373a8c6007a3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.