850214 - Update services/common/preferences.js usage of contentPrefs to nsIContentPrefService2

Status: RESOLVED FIXED

(Cloud Services :: Firefox: Common, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Use the new API added in bug 699859

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Remove site-specific support from preferences.js

Hey Richard, the preferences.js API supports a site-specific mode that uses the per-domain contentPrefs service instead of the regular prefs. However, the API from preferences.js is sync, and contentPrefs is moving to an async API (bug 831208).

*But*, site-specific mode is currently unused! So this patch just removes support for it from preferences.js.  Even if it was used, instead of changing preferences.js to async and totally re-engineering all of its many consumers, it'd be better to split site-specific mode into its own API and change only those consumers. But that won't even be necessary since it's not used right now.

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 727827 [details] [diff] [review]
Remove site-specific support from preferences.js

Review of attachment 727827 [details] [diff] [review]:
-----------------------------------------------------------------

Yay less code!

Comment 3

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/373a8c6007a3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/373a8c6007a3