Move XPIDL variables to moz.build files

RESOLVED FIXED in Thunderbird 22.0

Status

MailNews Core
Build Config
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

(Blocks: 1 bug)

unspecified
Thunderbird 22.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Assignee)

Description

4 years ago
comm-central needs work performed in bug 818246 applied to it.
(Assignee)

Comment 1

4 years ago
Created attachment 724122 [details] [diff] [review]
Part 2: Move IDLSRCS into moz.build (auto), v1

Conversion was performed automatically using our tried and true mach command. Review should largely be a rubber stamp.
Attachment #724122 - Flags: review?(Pidgeot18)
Comment on attachment 724122 [details] [diff] [review]
Part 2: Move IDLSRCS into moz.build (auto), v1

Consider this an rs+. All I did was eyeball most of the directories to see that roughly the same number of files were transferred; since it's automatic, I presume that all the spellings, etc. are safe. It also looks like you've picked up every directory in comm-central.

There are few manual things that need transferring as well though.
Attachment #724122 - Flags: review?(Pidgeot18) → review+

Updated

4 years ago
Blocks: 847009
(Assignee)

Comment 3

4 years ago
Created attachment 724249 [details] [diff] [review]
Part 1: rules.mk update, v1

Pretty much copied lines from m-c's rules.mk.
Attachment #724249 - Flags: review?(Pidgeot18)
(Assignee)

Comment 4

4 years ago
Created attachment 724250 [details] [diff] [review]
Part 2b: Move XPIDL_MODULE and XPIDL_FLAGS, v1

Conversion was done automatically. Should be a rubber stamp.
Attachment #724250 - Flags: review?(Pidgeot18)
(Assignee)

Comment 5

4 years ago
Created attachment 724251 [details] [diff] [review]
Part 3: Manual conversion, v1

Manual conversion of the remaining XPIDL* variables to moz.build (things in conditionals). You should give this a thorough review.

I haven't tested any of the patches in this bug. I'm really that lazy.
Assignee: nobody → gps
Status: NEW → ASSIGNED
Attachment #724251 - Flags: review?(Pidgeot18)
Comment on attachment 724249 [details] [diff] [review]
Part 1: rules.mk update, v1

Review of attachment 724249 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not a c-c build config peer, so I don't feel comfortable r+'ing this. Redirecting review to other people who can hopefully r+ this before the m-c patch lands.
Attachment #724249 - Flags: review?(mbanner)
Attachment #724249 - Flags: review?(kairo)
Attachment #724249 - Flags: review?(bugspam.Callek)
Attachment #724249 - Flags: review?(Pidgeot18)
Attachment #724249 - Flags: feedback+
Comment on attachment 724251 [details] [diff] [review]
Part 3: Manual conversion, v1

Review of attachment 724251 [details] [diff] [review]:
-----------------------------------------------------------------

::: ldap/xpcom/public/moz.build
@@ -17,5 @@
>      'nsILDAPService.idl',
>      'nsILDAPURL.idl',
>  ]
>  
> -XPIDL_MODULE = 'mozldap'

You dropped this line in the file.

Also, as mentioned over IRC, you forgot to remove the stuff from ldap/xpcom/public/Makefile.in.
Attachment #724251 - Flags: review?(Pidgeot18) → review+
Comment on attachment 724250 [details] [diff] [review]
Part 2b: Move XPIDL_MODULE and XPIDL_FLAGS, v1

I'll admit that I didn't try to compile with these patches, but I don't see anything untoward here. Although it is unusual to see such inherent Makefile syntax as -I$(topsrcdir)/ in the moz.build files, but as mozilla-central is using that syntax for its makefiles...
Attachment #724250 - Flags: review?(Pidgeot18) → review+

Updated

4 years ago
Attachment #724249 - Flags: review?(mbanner)
Attachment #724249 - Flags: review?(kairo)
Attachment #724249 - Flags: review?(bugspam.Callek)
Attachment #724249 - Flags: review+
(In reply to Joshua Cranmer [:jcranmer] from comment #6)
> I'm not a c-c build config peer, so I don't feel comfortable r+'ing this.
> Redirecting review to other people who can hopefully r+ this before the m-c
> patch lands.

To be extra clear, all other parts on this bug I feel are also explicitly build-system reviews, not just this one. However I feel comfortable with your review on all these patches, so carry-on.
(Assignee)

Comment 10

4 years ago
https://hg.mozilla.org/comm-central/rev/ea8f59513b2d
https://hg.mozilla.org/comm-central/rev/fef8c51030cc
https://hg.mozilla.org/comm-central/rev/10b5d6673cda
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 22.0
You need to log in before you can comment on or make changes to this bug.