Closed
Bug 850536
Opened 12 years ago
Closed 12 years ago
Performance improvement to FlattenSubstrings
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: h4writer, Assigned: h4writer)
References
Details
Attachments
(1 file)
|
3.12 KB,
patch
|
sstangl
:
review+
|
Details | Diff | Splinter Review |
I introduced FlattenSubstrings in #847682 . Looks like there is a small improvement possible over that implementation. This is a 8% improvement on "str92.replace(/\b\w+\b/g, '');". It has to concat a lot of matches and "stableStr->getChars(cx);" was showing in the profile.
(I also added a small nit. rdata.dollar is the first occurence of "$" in rdata.repstr. Because we test rdata.repstr->length() == 0, rdata.dollar should also not be set)
|
Assignee | |
Comment 1•12 years ago
|
||
Assignee: general → hv1989
Attachment #724273 -
Flags: review?(sstangl)
|
||
Updated•12 years ago
|
Attachment #724273 -
Flags: review?(sstangl) → review+
|
|
Assignee | |
Comment 2•12 years ago
|
||
Thanks for the quick review!
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb428b0e2167
|
||
Comment 3•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in
before you can comment on or make changes to this bug.
Description
•