850582 - [SMS] [Generic 'action-menu'] Remove dependencies with SMS App CSS.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Borja Salguero [:borjasalguero]]

Currently we are using class 'hide' that it's only part of SMS App CSS. On the other hand appending 'n' forms to element only hiding elements it's not the best option ;)

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 2

[satender]

Comment on attachment 724352 [details]
Pull Request

have reviewed and tested the change, looks good. at this point action_menu.js is completely independent of sms code.

Comment 3

[Maria Angeles Oteo (:oteo)]

We need it leo+ to impement the generic action menu necessary for the SMS leo+ US 838000, 838002, 838003, 838004 and 838005

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Blocking as this blocks several leo+ bugs

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 0a73439d3a82e3d148eca5685729ad32d33ba744
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 6

[Borja Salguero [:borjasalguero]]

John, for landing this one you should land first 848778 (it's marked in this bug as a dependency) because was backout.

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

That bug is marked as NO_UPLIFT.  I've asked for clarification in the bug to figure out if we should uplift it again.

Comment 8

[Julien Wajsberg [:julienw]]

v1-train: 8a4b7b86648c65ba68ad4d95aa19416f5627ae17