838002 - [SMS/MMS][User Story] Add phone number contact from message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Peter Dolanjski [:pdol]]

UCID: Messages-004

User Story:
As a user, I want the ability to add a phone number to a new or existing contact from a message so that I don't need to remember the number to manually enter it into my Contacts.

Comment 1

[Casey Yee]

UX draft ready for comment:
https://www.dropbox.com/s/1vp9z6ofjixhtj8/Messaging-AddContact.pdf

Comment 2

[satender]

Hi Casey,
I looked at the UX document, and I had one question. In the mocks, I see an explicit option "Add Contacts", corresponding to (2) screen, where you say "Tapping Add to Contacts opens value selection"

When I was playing with the SMS app which is out there right now with 1.0, I noticed if you were to tap on the number which is not in contacts yet, which in your example screenshot 2 is, "604 321 4567", today the user is taken to the "Add new Contact" screen directly.

So, I was wondering, should we just enhance this existing functionality to show multiple options to the user when the user clicks on "604 321 4567" to do what u suggest:
1. Show the overlay "Add to Contacts Action Menu"
2. and then let the flow be as you have in the UX draft.

Basically my question is, should we leave the trigger for "Add to Contacts Action Menu" to be the "Phone number" in the title or we create a new "Add to Contacts" option, and remove the existing trigger which is there on the "Phone number" in the title.

I hope I am clear here.

Comment 3

[satender]

Attachment: screenshot showing the SMS screen with number which is not yet in contacts

attaching screenshot showing the current SMS screen when the number from which SMS was received is not in the contacts, in this screenshot that number is: 91-9871502381.

Currently, when user clicks on the title i.e. 91-9871502381, it takes the user to the "Add New Contact" screen.

Comment 4

[Casey Yee]

I misread the user story.  There are two methods by which the user should be able to add phone numbers from within the messaging app:
1) Message thread with phone number that is not associated with contact.  The spec that I posted to this bug covers this requirement.
2) Phone numbers within messages.

For scenario 2 what should happen is when you tap on the phone number from within the message.  You should see a action menu with:  
1) Create new contact
2) Add to Existing contact
3) Dial number
4) Send new message

Thoughts?

Comment 5

[satender]

Regarding Scenario 1 for which you have posted the spec, everything looks good. Only one point here: 
a )Should the trigger to show the action menu with 2 options "Create New Contact" and "Add to Existing Contact" be a tap on the "unlisted phone number" in the title, 
or 
b) do we add an explicit "Add to Contacts" header and the user taps that header to trigger the action menu.

The reason I ask is, because currently there is half functionality implemented for option (a). 

Regarding scenario 2, it all makes perfect sense. The only comment here is that "Send new message" feature is being tracked as a separate bug, so we will address it in a separate bug 838022, as per Dylan's comments here:
https://bugzilla.mozilla.org/show_bug.cgi?id=838000#c4

Comment 6

[Borja Salguero [:borjasalguero]]

This one it's fixed by 838000. I would mark this one as duplicated, and I would change the name of 838000 to '[SMS/MMS][User Story] New activities invocation from message' for getting a generic one. Otherwise we should split the PR in 2 (one for this and one for 838000).

Comment 7

[satender]

I guess, with this bug 838002 we can track the Scenario 1 as mentioned by Casey in comment #4 "Message thread with phone number that is not associated with contact.  The spec that I posted to this bug covers this requirement."

while we use 838000 for Scenario 2 mentioned by Casey in comment#4 "Phone numbers within messages.".That bug already has screenshot from UX for the scenario.

That way, each bug can have its own PR.

Comment 8

[Casey Yee]

(In reply to satender from comment #5)
> Regarding Scenario 1 for which you have posted the spec, everything looks
> good. Only one point here: 
> a )Should the trigger to show the action menu with 2 options "Create New
> Contact" and "Add to Existing Contact" be a tap on the "unlisted phone
> number" in the title, 
> or 
> b) do we add an explicit "Add to Contacts" header and the user taps that
> header to trigger the action menu.
> 
> The reason I ask is, because currently there is half functionality
> implemented for option (a). 

Let's go with option A then.   I updated the spec at the same url to fit with this description.   My only issue with this approach is that it's less discoverable, but we also gain the ability to add more actions to the options list so I think it's a good change overall.

Comment 9

[satender]

Thanks Casey. will incorporate option A once the 838000 is merged to master.

Comment 10

[Dietrich Ayala (:dietrich)]

Satender, what's your estimate for completing this bug? Thanks!

Comment 11

[Borja Salguero [:borjasalguero]]

Hi Dietrich,
We are going to follow the following steps https://github.com/mozilla-b2g/gaia/pull/8159#issuecomment-14554460

Comment 12

[Dietrich Ayala (:dietrich)]

Per partner and release-driver discussions, marking blocking- until all MMS functionality in bug 849867 is complete, allowing it all to be checked-in at once to avoid SMS bustage.

Comment 13

[Dylan Oliver [:doliver]]

Restoring leo+ for the non-MMS dependent v1.1 SMS features.

Comment 14

[Maria Angeles Oteo (:oteo)]

Attachment: Acceptance criteria for US 838002

Comment 15

[Maria Angeles Oteo (:oteo)]

Attachment: Acceptance criteria for US 838002

Comment 16

[ayman maat :maat]

Attachment: HTML5_SMS-MMSUserStorySpecifications_20130315_V1.0

Wireframe release:
HTML5_SMS-MMSUserStorySpecifications_20130315_V1.0

**new wireframes**
- SMS with phone number
- Phone number long press options
- Phone number not in contact list options
- SMS with URL
- SMS with email
- Email long press options

**updated wireframes**
- none

**deleted wireframes**
- none


to address this bug specifically refer to page: 6

Comment 17

[Jason Smith [:jsmith]]

This might be TEF or Taipei owning testing here.

Tony - Can you find out who owns this user story?

Comment 18

[Maria Angeles Oteo (:oteo)]

(In reply to Jason Smith [:jsmith] from comment #17)
> This might be TEF or Taipei owning testing here.
> 
> Tony - Can you find out who owns this user story?

The testing of this US owns to TEF team, they are preparing the test plan for it

Comment 19

[satender]

Attachment: PR to allow adding a phone number or calling on single tap from header of sms message

https://github.com/mozilla-b2g/gaia/pull/8824

Comment 20

[satender]

Comment on attachment 729489 [details] [review]
PR to allow adding a phone number or calling on single tap from header of sms message

adding l10n to review l10n string.

Comment 21

[Borja Salguero [:borjasalguero]]

Comment on attachment 729489 [details] [review]
PR to allow adding a phone number or calling on single tap from header of sms message

From my side R+. Only waiting l10n team. Please squash your changes!

Comment 22

[Maria Angeles Oteo (:oteo)]

Attachment: Acceptance criteria for US 838002

Updated Acceptance Criteria agreed with UX team and development, so QA team can update their test cases according to it

Comment 23

[satender]

(In reply to Borja Salguero [:borjasalguero] (On Holidays until Tuesday 2nd) from comment #21)

> From my side R+. Only waiting l10n team. Please squash your changes!

have squashed the changes.

Comment 24

[Staś Małolepszy :stas]

Comment on attachment 729489 [details] [review]
PR to allow adding a phone number or calling on single tap from header of sms message

r+ for landing on master and v1-train

Comment 25

[Julien Wajsberg [:julienw]]

master: 99a78752f3c99518fc17fb73055860298bdcb386

Comment 26

[Julien Wajsberg [:julienw]]

v1-train: d3bf49f961e59d7d92b73e0aa317e183572fb546