Adding a gain node to the graph without setting its value mutes audio

RESOLVED FIXED in mozilla22

Status

()

defect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla22
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Assignee

Description

6 years ago
That's because we forget to send the gain parameter to the MSG, so the GainNodeEngine's mGain value will be 0, hence the audio will be muted.
Assignee

Updated

6 years ago
Blocks: webaudio
Assignee

Comment 1

6 years ago
Posted file Testcase
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Assignee

Comment 2

6 years ago
Posted patch Patch (v1) (obsolete) — Splinter Review
Attachment #724764 - Flags: review?(roc)
Comment on attachment 724764 [details] [diff] [review]
Patch (v1)

Review of attachment 724764 [details] [diff] [review]:
-----------------------------------------------------------------

Wouldn't it be just as simple and slightly more efficient to default the gain to 1 in a new GainNodeEngine?
Assignee

Comment 4

6 years ago
Posted patch Patch (v2) (obsolete) — Splinter Review
Good idea.
Attachment #724764 - Attachment is obsolete: true
Attachment #724764 - Flags: review?(roc)
Attachment #724867 - Flags: review?(roc)
Assignee

Comment 5

6 years ago
Posted patch Patch (v3)Splinter Review
In fact, let's just remove the constructor which is going to make future similar bugs possible!
Attachment #724867 - Attachment is obsolete: true
Attachment #724867 - Flags: review?(roc)
Attachment #724871 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/1fcad70f70b7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Assignee

Comment 8

6 years ago
Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in before you can comment on or make changes to this bug.